Skip to content

Fixes to PR template #11899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 21, 2019
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 17 additions & 21 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,20 +1,18 @@
<!--
For more information on the requirements for pull requests, please see [the contributing guidelines](https://os.mbed.com/docs/mbed-os/latest/contributing/workflow.html#pull-request-types).
For more information on the requirements for pull requests, please see [the contributing guidelines](https://os.mbed.com/docs/mbed-os/latest/contributing/workflow.html).
-->
### Description (*required*)

<!--
Required
Add here detailed changes summary, testing results, dependencies
Good example: https://os.mbed.com/docs/mbed-os/latest/contributing/workflow.html (Pull request template)
-->
##### Summary of change (*What the change is for and why*)
### Description
#### Summary of change <!-- Required -->

<!-- Basic information about the change: what the change is for, why do we need it any implications -->

#### Documentation <!-- Optional, but most likely you need it -->

##### Documentation (*Details of any document updates required*)
<!-- Details of any document updates required, including links to PR against the docs repository -->

----------------------------------------------------------------------------------------------------------------
### Pull request type (*required*)
### Pull request type <!-- Required -->

<!--
Required
Expand All @@ -28,39 +26,37 @@ For more information on the requirements for pull requests, please see [the cont
[] Major update (Breaking change E.g. Return code change / API behaviour change)

----------------------------------------------------------------------------------------------------------------
### Test results (*required*)
### Test results <!-- Required -->

<!--
Required
For example, add test results for new target
Provide all the information required, listing all the testing performed. For new targets please attach full test results
for all supported compilers.
-->
[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR


----------------------------------------------------------------------------------------------------------------
### Reviewers (*optional*)
### Reviewers <!-- Optional -->

<!--
Optional
Request additional reviewers with @username
Request additional reviewers with @username or @team
-->

----------------------------------------------------------------------------------------------------------------
### Release Notes (*required for feature/major PRs*)
### Release Notes <!-- Required for features, deprecations, breaking changes and other major PRs -->

<!--
All 3 sections are compulsory for Major PR types. For Feature PRs only the summary section is required.
This section is automatically added to release notes. Please fill in each sub-section with sufficient detail for a user.
For more information, please see [the contributing guidelines](https://os.mbed.com/docs/mbed-os/latest/contributing/workflow.html#pull-request-types).
-->

##### Summary of changes

##### Impact of changes

##### Migration actions required

#### Summary of changes

#### Impact of changes

#### Migration actions required