TOOLS: enable build greentea test coverage for HW #11904

jamesbeyond · 2019-11-20T10:11:28Z

Description (required)

This PR adds a hidden option --coverage-filters to the mbed test function. this option allows filters to be passed into the tests building stage. for the files matches with filters will be compiled with a gcov option, the rest of the files will be covered by the default compiler options.

Summary of change (What the change is for and why)

This option is key to enabling code coverage from HW, only in the way the gcov complied images should be small enough to fit a HW target
This option only applies to GCC_ARM toolchain, no impact to other toolchains
This option is not visible from mbed test --help , so no public users impact, because the function is still in an experimental stage.
for the file that matches with given filter compiler options --coverage, -DENABLE_LIBGCOV_PORT are added
linker options --coverage, -Wl,--wrap,GREENTEA_SETUP, -Wl,--wrap,_Z25GREENTEA_TESTSUITE_RESULTi are added if the option is enabled.
if the option is not in use normal mbed test option will not get impacted

Documentation (Details of any document updates required)

becasue this is

Pull request type (required)

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results (required)

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers (optional)

@mark-edgeworth

Release Notes (required for feature/major PRs)

Summary of changes

Impact of changes

Migration actions required

ciarmcom · 2019-11-20T12:00:35Z

@jamesbeyond, thank you for your changes.
@mark-edgeworth @ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

tools/toolchains/arm.py

mark-edgeworth · 2019-11-27T13:20:03Z

tools/toolchains/iar.py

@@ -44,7 +44,7 @@ def check_executable():
        )

    def __init__(self, target, notify=None, macros=None, build_profile=None,
-                 build_dir=None):
+                 build_dir=None, coverage_patterns=None):


As for arm.py; change only applies for gcc-arm so no need to change here.

please see my above comments, about why ARM and IAR need to be changed as well.

mark-edgeworth · 2019-11-27T13:22:28Z

tools/toolchains/gcc.py

+        self.coverage_cppc = self.cppc + ["--coverage", "-DENABLE_LIBGCOV_PORT"]
+        self.coverage_ld = self.ld + ['--coverage', '-Wl,--wrap,GREENTEA_SETUP', '-Wl,--wrap,_Z25GREENTEA_TESTSUITE_RESULTi']
+
+        for flag in ["-DMBED_DEBUG"]:


Could do with a comment here explaining what this is doing, and more importantly why.

comments added

mark-edgeworth · 2019-11-27T13:22:59Z

tools/toolchains/gcc.py

@@ -208,6 +223,12 @@ def get_compile_options(self, defines, includes, for_asm=False):
            opts = opts + self.get_config_option(config_header)
        return opts

+    def match_coverage_patterns(self, source):
+        for pattern in self.coverage_patterns:


Document what this new function is doing.

comments added

mark-edgeworth · 2019-11-27T13:23:50Z

tools/toolchains/arm.py

    ):
        ARM.__init__(
            self,
            target,
            notify,
            macros,
            build_dir=build_dir,
-            build_profile=build_profile
+            build_profile=build_profile,
+            coverage_patterns=None


Shouldn't need to change this - gcc-arm only

please see my above comments, about why ARM and IAR need to be changed as well.

adbridge · 2019-12-13T15:20:28Z

@jamesbeyond could you please take a look at the review comments ?

jamesbeyond · 2020-01-03T17:27:56Z

the asked changes been addressed, could you review again ? @mark-edgeworth

Needs new review

adbridge · 2020-01-20T15:19:35Z

Ci started

mbed-ci · 2020-01-20T16:18:09Z

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

TOOLS: enable build greentea test with gcov options

4482556

ciarmcom requested review from mark-edgeworth and a team November 20, 2019 12:00

ciarmcom added the needs: review label Nov 20, 2019

TOOLS: fix failed python test

e6fe03f

mark-edgeworth previously requested changes Nov 27, 2019

View reviewed changes

adbridge added needs: work and removed needs: review labels Dec 13, 2019

TOOLS: add some inline comments

d047b28

adbridge added needs: review and removed needs: work labels Jan 6, 2020

0xc0170 requested a review from mark-edgeworth January 17, 2020 14:12

0xc0170 approved these changes Jan 17, 2020

View reviewed changes

mark-edgeworth approved these changes Jan 20, 2020

View reviewed changes

0xc0170 added needs: CI and removed needs: review labels Jan 20, 2020

mergify bot added ready for merge and removed needs: CI labels Jan 20, 2020

adbridge added release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0 and removed ready for merge labels Jan 21, 2020

adbridge merged commit 48f90c0 into ARMmbed:master Jan 21, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

TOOLS: enable build greentea test coverage for HW #11904

TOOLS: enable build greentea test coverage for HW #11904

Uh oh!

jamesbeyond commented Nov 20, 2019 •

edited

Loading

Uh oh!

ciarmcom commented Nov 20, 2019

Uh oh!

Uh oh!

mark-edgeworth Nov 27, 2019

Uh oh!

jamesbeyond Jan 3, 2020

Uh oh!

mark-edgeworth Nov 27, 2019

Uh oh!

jamesbeyond Jan 3, 2020

Uh oh!

mark-edgeworth Nov 27, 2019

Uh oh!

jamesbeyond Jan 3, 2020

Uh oh!

mark-edgeworth Nov 27, 2019

Uh oh!

jamesbeyond Jan 3, 2020

Uh oh!

adbridge commented Dec 13, 2019

Uh oh!

jamesbeyond commented Jan 3, 2020

Uh oh!

adbridge commented Jan 20, 2020

Uh oh!

mbed-ci commented Jan 20, 2020

Uh oh!

Uh oh!

TOOLS: enable build greentea test coverage for HW #11904

TOOLS: enable build greentea test coverage for HW #11904

Uh oh!

Conversation

jamesbeyond commented Nov 20, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (required)

Summary of change (What the change is for and why)

Documentation (Details of any document updates required)

becasue this is

Pull request type (required)

Test results (required)

Reviewers (optional)

Release Notes (required for feature/major PRs)

Summary of changes

Impact of changes

Migration actions required

Uh oh!

ciarmcom commented Nov 20, 2019

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

adbridge commented Dec 13, 2019

Uh oh!

jamesbeyond commented Jan 3, 2020

Uh oh!

adbridge commented Jan 20, 2020

Uh oh!

mbed-ci commented Jan 20, 2020

Uh oh!

Uh oh!

jamesbeyond commented Nov 20, 2019 •

edited

Loading