-
Notifications
You must be signed in to change notification settings - Fork 3k
I2C byte read/write transmition improvement #11908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@0xc0170 Please review. |
@yarbcy, thank you for your changes. |
@yarbcy Can you please extend the commit msg - add details from the release notes. As this is a fix, release notes are not needed for this fix (will be ignored). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM, just extend the commit message please
796c9a9
to
7d5f21d
Compare
…ER to clear CY_SCB_I2C_WRITE_XFER status in i2c_byte_write() API.
7d5f21d
to
3d09a5a
Compare
Done. |
For future reference, keep the first line up to 50 char (you can see how the line is wrapped here), use second paragraph that could be longer (~80 char) and describe detailed changes. |
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Description (required)
I2C byte read/write transmition improvement
Summary of change (What the change is for and why)
Documentation (Details of any document updates required)
Pull request type (required)
Test results (required)
Reviewers (optional)
Release Notes (required for feature/major PRs)
Summary of changes
Issue while calling - "MASTER_IS_NOT_READY":
i2c_start(&i2c);
i2c_byte_write(&i2c, (I2C_DEV_ADDR | 1));//send device address for reading
data_in[i] = i2c_byte_read(&i2c, 1);
Added CY_SCB_I2C_READ_XFER to clear CY_SCB_I2C_WRITE_XFER status in i2c_byte_write() API.
Impact of changes
Cypress
Migration actions required
N/A