Skip to content

I2C byte read/write transmition improvement #11908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2019

Conversation

yarbcy
Copy link
Contributor

@yarbcy yarbcy commented Nov 20, 2019

Description (required)

I2C byte read/write transmition improvement

Summary of change (What the change is for and why)
Documentation (Details of any document updates required)

Pull request type (required)

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results (required)

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers (optional)


Release Notes (required for feature/major PRs)

Summary of changes

Issue while calling - "MASTER_IS_NOT_READY":

i2c_start(&i2c);
i2c_byte_write(&i2c, (I2C_DEV_ADDR | 1));//send device address for reading
data_in[i] = i2c_byte_read(&i2c, 1);

Added CY_SCB_I2C_READ_XFER to clear CY_SCB_I2C_WRITE_XFER status in i2c_byte_write() API.

Impact of changes

Cypress

Migration actions required

N/A

@yarbcy
Copy link
Contributor Author

yarbcy commented Nov 20, 2019

@0xc0170 Please review.

@ciarmcom ciarmcom requested review from maclobdell and a team November 20, 2019 16:00
@ciarmcom
Copy link
Member

@yarbcy, thank you for your changes.
@maclobdell @ARMmbed/mbed-os-maintainers please review.

@yarbcy
Copy link
Contributor Author

yarbcy commented Nov 21, 2019

@0xc0170 @mprse This PR is related to FPGA tests. Please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 21, 2019

@yarbcy Can you please extend the commit msg - add details from the release notes. As this is a fix, release notes are not needed for this fix (will be ignored).

Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, just extend the commit message please

…ER to clear CY_SCB_I2C_WRITE_XFER status in i2c_byte_write() API.
@yarbcy yarbcy force-pushed the pr/i2c-improvement3 branch from 7d5f21d to 3d09a5a Compare November 21, 2019 09:42
@yarbcy
Copy link
Contributor Author

yarbcy commented Nov 21, 2019

@yarbcy Can you please extend the commit msg - add details from the release notes. As this is a fix, release notes are not needed for this fix (will be ignored).

Done.

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 21, 2019

For future reference, keep the first line up to 50 char (you can see how the line is wrapped here), use second paragraph that could be longer (~80 char) and describe detailed changes.

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 21, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Nov 21, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 removed the needs: CI label Nov 21, 2019
@0xc0170 0xc0170 merged commit ab7f602 into ARMmbed:master Nov 21, 2019
@yarbcy yarbcy deleted the pr/i2c-improvement3 branch January 10, 2020 16:59
@yarbcy yarbcy restored the pr/i2c-improvement3 branch January 10, 2020 16:59
@yarbcy yarbcy deleted the pr/i2c-improvement3 branch January 10, 2020 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants