Skip to content

Cypress: FPGA: Improve SPI async calls #11919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 22, 2019
Merged

Cypress: FPGA: Improve SPI async calls #11919

merged 1 commit into from
Nov 22, 2019

Conversation

yarbcy
Copy link
Contributor

@yarbcy yarbcy commented Nov 21, 2019

  1. Enabled events in proper place
  2. Added check in async operation is in progress

Description

Summary of change

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

Release Notes

Summary of changes

See commit message.

Impact of changes

Cypress

Migration actions required

N/A

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 21, 2019 •
edited
Loading

This improvement is fixing anything? Why we did not have that flag spi in progress before?

@yarbcy
Copy link
Contributor Author

yarbcy commented Nov 21, 2019

This improvement is fixing anything? Why we did not have that flag spi in progress before?

Thanks for such question. Before FPGA SPI async test case was failed, now it passes.

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 21, 2019

Would it make sense to state in the commit itself ? These improvements should fix something (spi asyn write/read, or similar). If anyone comes to this commit, would know what should be fixed (in case its not, will question it).

@yarbcy
Copy link
Contributor Author

yarbcy commented Nov 21, 2019

Would it make sense to state in the commit itself ? These improvements should fix something (spi asyn write/read, or similar). If anyone comes to this commit, would know what should be fixed (in case its not, will question it).

OK.

Cypress: FPGA: Improve SPI async calls
b204acb 
1. Fix for FPGA async test case.
2. Enabled events in proper place
3. Added check in async operation is in progress
@yarbcy yarbcy force-pushed the pr/spi-async-improvement2 branch from 00f8116 to b204acb Compare November 21, 2019 15:23
@yarbcy
Copy link
Contributor Author

yarbcy commented Nov 21, 2019

@0xc0170 Done.

@ciarmcom ciarmcom requested review from maclobdell and a team November 21, 2019 16:00
@ciarmcom
Copy link
Member

@yarbcy, thank you for your changes.
@maclobdell @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 22, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Nov 22, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 removed the needs: CI label Nov 22, 2019
@0xc0170 0xc0170 merged commit 55bfb00 into ARMmbed:master Nov 22, 2019
@yarbcy yarbcy deleted the pr/spi-async-improvement2 branch January 10, 2020 16:59
@yarbcy yarbcy restored the pr/spi-async-improvement2 branch January 10, 2020 16:59
@yarbcy yarbcy deleted the pr/spi-async-improvement2 branch January 10, 2020 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@maclobdell maclobdell Awaiting requested review from maclobdell

Assignees
No one assigned
Labels
devices: cypress release-version: 5.15.0-rc1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yarbcy @0xc0170 @ciarmcom @mbed-ci