Skip to content

STM32: Update and align serial_clear implementations #11938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 27, 2019

Conversation

LMESTM
Copy link
Contributor

@LMESTM LMESTM commented Nov 25, 2019

Description

Clear RXNE flag by reading the RX register and align this implementation on all families.

Summary of change

This solves the issue reported here: #11893

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[x] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

There is no known tests for serial_clear API. 
Also there is no clear documentation of what behavior is actually expected from serial_clear. This implementation is based on current understanding.

Reviewers

@ARMmbed/team-st-mcd

Clear RXNE flag by reading the RX register and align this implementation
on all families.
@ciarmcom ciarmcom requested a review from a team November 25, 2019 14:00
@ciarmcom
Copy link
Member

@LMESTM, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 27, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Nov 27, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 27, 2019

@ARMmbed/team-st-mcd Any review, looks like this is ready almost

@0xc0170 0xc0170 merged commit a1cddba into ARMmbed:master Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants