Skip to content

Revert "MbedCRC and CRC HAL revisions" #11946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 27, 2019
Merged

Revert "MbedCRC and CRC HAL revisions" #11946

merged 1 commit into from
Nov 27, 2019

Conversation

0xc0170
Copy link
Contributor

@0xc0170 0xc0170 commented Nov 26, 2019

Description

Summary of change

Revert PR #11559 (it will be recreated once 5.15rc1 is out along with the fix #11896).

This fixes master and 5.15 and client integration testing, the new PR will be created

Documentation


Pull request type

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[X] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[X] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


Release Notes

Summary of changes

Impact of changes

Migration actions required

@0xc0170 0xc0170 requested a review from kjbracey November 26, 2019 13:53
@0xc0170
Copy link
Contributor Author

0xc0170 commented Nov 26, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Nov 26, 2019

Test run: FAILED

Summary: 1 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-IAR

@0xc0170
Copy link
Contributor Author

0xc0170 commented Nov 26, 2019

CI restarted

@mbed-ci
Copy link

mbed-ci commented Nov 26, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@0xc0170
Copy link
Contributor Author

0xc0170 commented Nov 27, 2019

CI passed, landing

@0xc0170 0xc0170 removed the needs: CI label Nov 27, 2019
@0xc0170 0xc0170 merged commit b0751bf into master Nov 27, 2019
@kjbracey
Copy link
Contributor

New PR to reapply it is #11957

@0xc0170 0xc0170 deleted the revert-11559-crc branch October 5, 2021 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants