Skip to content

Bug in mbed_alloc_wrappers.cpp #11962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

DBS06
Copy link
Contributor

@DBS06 DBS06 commented Nov 27, 2019

Description

regarding issue #11960

Setting
"platform.heap-stats-enabled": false,
"platform.memory-tracing-enabled": false,
in mbed_app.json does not deactivate tracing in mbed_alloc_wrappers.cpp

Summary of change

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


Release Notes

Summary of changes

Impact of changes

Migration actions required

…ABLED with #if MBED_MEM_TRACING_ENABLED and #if MBED_HEAP_STATS_ENABLED
@0xc0170
Copy link
Contributor

0xc0170 commented Nov 27, 2019

Can you add more to Description - what is this fixing , etc - details from the issue report.

@ciarmcom ciarmcom requested review from a team November 27, 2019 16:00
@ciarmcom
Copy link
Member

@DBS06, thank you for your changes.
@ARMmbed/mbed-os-core @ARMmbed/mbed-os-maintainers please review.

@evedon
Copy link
Contributor

evedon commented Nov 28, 2019

This change is not required, see #11960 (comment)

@DBS06
Copy link
Contributor Author

DBS06 commented Nov 28, 2019

@evedon should I close this PR?

@bulislaw
Copy link
Member

This should work for both cases when the macro is not defined and where it set to false, why do we want to close it? Sure it doesn't address the whole configuration, but it does the right thing for this module. Or am I missing something?

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 29, 2019

I would expect it to work, as it is in this PR

@kjbracey
Copy link
Contributor

kjbracey commented Nov 29, 2019

I do approve this, but I would approve it harder it if also adjusted the JSON to change the default nulls to false.

EDIT: Although, on second thoughts, that might actually be a small breakage risk. It's possible some application or external code might be doing #ifdef itself and hence relying on null == off. Maybe do that separately, and file for 6.0. This is fine as a patch.

@0xc0170 0xc0170 added needs: CI release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0 and removed needs: review labels Dec 2, 2019
@mbed-ci
Copy link

mbed-ci commented Dec 2, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 removed the needs: CI label Dec 2, 2019
@0xc0170 0xc0170 merged commit 111d1ca into ARMmbed:master Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants