-
Notifications
You must be signed in to change notification settings - Fork 3k
Bug in mbed_alloc_wrappers.cpp #11962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug in mbed_alloc_wrappers.cpp #11962
Conversation
…ABLED with #if MBED_MEM_TRACING_ENABLED and #if MBED_HEAP_STATS_ENABLED
Can you add more to |
@DBS06, thank you for your changes. |
This change is not required, see #11960 (comment) |
@evedon should I close this PR? |
This should work for both cases when the macro is not defined and where it set to false, why do we want to close it? Sure it doesn't address the whole configuration, but it does the right thing for this module. Or am I missing something? |
I would expect it to work, as it is in this PR |
I do approve this, but I would approve it harder it if also adjusted the JSON to change the default EDIT: Although, on second thoughts, that might actually be a small breakage risk. It's possible some application or external code might be doing |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Description
regarding issue #11960
Setting
"platform.heap-stats-enabled": false,
"platform.memory-tracing-enabled": false,
in
mbed_app.json
does not deactivate tracing inmbed_alloc_wrappers.cpp
Summary of change
Documentation
Pull request type
Test results
Reviewers
Release Notes
Summary of changes
Impact of changes
Migration actions required