Fixed crashing nsapi_dns unittest #11967
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added missing "return" for NetworkStackMock's get_stack() method
michalpasztamobica
approved these changes
Nov 28, 2019
|
@AnttiKauppila, thank you for your changes. |
AriParkkila
approved these changes
Nov 28, 2019
0xc0170
approved these changes
Nov 28, 2019
|
CI started |
Test run: SUCCESSSummary: 1 of 1 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added missing "return" for NetworkStackMock's get_stack() method
Description
Summary of change
nsapi_dns unittest is crashing in local environment due to missing return in NetworkStackMock's get_stack() function. This PR adds the missing return and fixes the problem.
Documentation
Pull request type
Test results
Reviewers
@michalpasztamobica
Release Notes
Summary of changes
Impact of changes
Migration actions required