Avoid crashes during fault handler #11970
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjbracey
force-pushed
the
fault_crash
branch
2 times, most recently
from
0130151 to
bc7e217
Compare
|
@kjbracey-arm, thank you for your changes. |
If the fault handler was hit before the stdio console was used and initialised, the initialisation code caused a "mutex in ISR" trap, stopping the register dump from happening. Temporarily set the `error_in_progress` flag at the top of the fault handler, and restore it before calling `mbed_error`. Take the opportunity to suppress fault dumps on recursive crashes, much as is done inside `mbed_error`.
kjbracey
force-pushed
the
fault_crash
branch
from
bc7e217 to
fc05d51
Compare
0xc0170
approved these changes
Dec 2, 2019
bulislaw
approved these changes
Dec 3, 2019
|
CI started |
0xc0170
added
the
release-version: 6.0.0-alpha-1
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
|
This is a pretty straightforward and important fix - it should be for 5.15.1 |
After 5.15, there will be 6.0. This could be requested to get in rc2. I'll merge this and we can fix version if agreed. |
0xc0170
added
release-version: 5.15.0-rc2
and removed
release-version: 6.0.0-alpha-1
|
Set to 5.15.0rc2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of change
If the fault handler was hit before the stdio console was used and initialised, the initialisation code caused a "mutex in ISR" trap, stopping the register dump from happening.
Temporarily set the
error_in_progressflag at the top of the fault handler, and restore it before callingmbed_error. Take the opportunity to suppress fault dumps on recursive crashes, much as is done insidembed_error.Fixes #11584.
Pull request type
Test results