Skip to content

Ublox Odin Driver OS 5 v3.7.1 rc3: Network-WiFi Test Crash Fixes #11983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 4, 2019
Merged

Ublox Odin Driver OS 5 v3.7.1 rc3: Network-WiFi Test Crash Fixes #11983

merged 2 commits into from
Dec 4, 2019

Conversation

hmxmghl
Copy link
Member

@hmxmghl hmxmghl commented Nov 29, 2019

Description

This PR contains

  • Bug fixes in the Odin Interface and EMAC layer that were causing the Message Pool to overflow and other uncertain crashes.

Fixes for following issues

Summary of change

  • Odin Interface and EMAC Driver Updated.

Test Results

test-report_IAR_ublox_odin_driver_os_5_v3.7.1_rc3_mbed-os-tests.log
test-report_ARMC6_ublox_odin_driver_os_5_v3.7.1_rc3_mbed-os-tests.log
test-report_GCC_ARM_ublox_odin_driver_os_5_v3.7.1_rc3_mbed-os-tests.txt
test-report_ARMC6_ublox_odin_driver_os_5_v3.7.1_rc3_mbed-os-example-pelion.log

Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[ ] Feature update (New feature / Functionality change / New API)
[ ] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[ ] No Tests required for this change (E.g docs only update)
[ ] Covered by existing mbed-os tests (Greentea or Unittest)
[X] Tests / results supplied as part of this PR

Reviewers

@ciarmcom ciarmcom requested review from kimlep01 and a team November 29, 2019 08:00
@ciarmcom
Copy link
Member

@hamza-ubx, thank you for your changes.
@kimlep01 @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

@hmxmghl hmxmghl force-pushed the ublox_odin_driver_os_5_v3.7.1_rc3 branch from bad02a3 to c15320d Compare November 29, 2019 09:52
@mbed-ci
Copy link

mbed-ci commented Nov 29, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

0xc0170
0xc0170 requested changes Dec 2, 2019
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some cosmetic requests found, otherwise looks fine to me

@hmxmghl hmxmghl requested a review from 0xc0170 December 3, 2019 06:52
kimlep01
kimlep01 approved these changes Dec 3, 2019
View reviewed changes
Copy link

@kimlep01 kimlep01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was extensively tested in #10815. I have run netsocket/network tests for this PR manually with UBLOX_EVK_ODIN_W2.

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 3, 2019 •
edited
Loading

CI restarted

@mbed-ci
Copy link

mbed-ci commented Dec 3, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 2
Build artifacts

@0xc0170 0xc0170 removed the needs: CI label Dec 4, 2019
@0xc0170 0xc0170 merged commit bbf68d7 into ARMmbed:master Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@kimlep01 kimlep01 kimlep01 approved these changes

@michalpasztamobica michalpasztamobica michalpasztamobica approved these changes

Assignees
No one assigned
Labels
release-version: 5.15.0-rc2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UBLOX_EVK_ODIN_W2: network-wifi test crashes
6 participants
@hmxmghl @ciarmcom @mbed-ci @0xc0170 @kimlep01 @michalpasztamobica