MCU_NRF52840 target configuration fixes #11995
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xc0170
requested changes
Dec 2, 2019
| "detect_code": ["1026"], | ||
| "device_has_remove": ["ITM"], | ||
| "macros_add": [ | ||
| "CONFIG_GPIO_AS_PINRESET", | ||
| "NRF52_ERRATA_20" |
There was a problem hiding this comment.
I don't see this set in the parent, why are we removing it ?
There was a problem hiding this comment.
It has been erroneously added here. As PR #11706 tells the define is incorrect and the correct one can be found from under MCU_NRF52840.
| "device_has_remove": ["QSPI", "ITM"], | ||
| "device_has_add": ["FLASH"], |
There was a problem hiding this comment.
this one is neither set in the MCU_NRF52840 ?
There was a problem hiding this comment.
All three - BLE, FLASHIAP and FLASH - are already defined under MCU_NRF52840
"MCU_NRF52840": {
"inherits": ["Target"],
"components_add": ["QSPIF", "FLASHIAP"],
"core": "Cortex-M4F",
"macros": [
"BOARD_PCA10056",
"NRF52840_XXAA",
"TARGET_NRF52840",
"CMSIS_VECTAB_VIRTUAL",
"CMSIS_VECTAB_VIRTUAL_HEADER_FILE=\"cmsis_nvic.h\"",
"MBED_TICKLESS",
"MBEDTLS_CONFIG_HW_SUPPORT",
"WSF_MAX_HANDLERS=10",
"MBED_MPU_CUSTOM",
"SWI_DISABLE0",
"NRF52_PAN_20"
],
"features": ["CRYPTOCELL310", "BLE"],
"device_has": [
"ANALOGIN",
"FLASH",
```
SeppoTakalo
approved these changes
Dec 2, 2019
0xc0170
approved these changes
Dec 2, 2019
|
CI started |
0xc0170
added
the
release-version: 6.0.0-alpha-1
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of change
Fixes NRF52840_DK target configuration and removes redundancies between all MCU_NRF52840_DK based boards.
NRF52840_DK target code fixed, should be
1102Moved configurations shared by all the boards MCU_NRF52840_DK based boards under MCU_NRF52840_DK.
Documentation
Pull request type
Test results
Reviewers
@0xc0170
@AnttiKauppila
@SeppoTakalo
Release Notes
Summary of changes
Impact of changes
Migration actions required