Skip to content

Remove deprecated FunctionPointer class #11997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 19, 2019
Merged

Remove deprecated FunctionPointer class #11997

merged 1 commit into from
Dec 19, 2019
+0 −648

Conversation

kjbracey
Copy link
Contributor

@kjbracey kjbracey commented Dec 2, 2019

Description

Summary of change

FunctionPointer has been deprecated in favour of Callback since 5.1 - remove it.

Documentation

None required, I believe - I can't see it in the docs.

Pull request type 

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[X] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[X] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

Release Notes

Summary of changes

  • Deprecated class FunctionPointer has been removed.

Impact of changes

  • Any code using FunctionPointer will no longer compile.

Migration actions required

  • Any remaining FunctionPointer users should switch to Callback.

@adbridge
Copy link
Contributor

CI started

@mbed-ci
Copy link

mbed-ci commented Dec 13, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 requested a review from bulislaw December 16, 2019 08:45
@0xc0170 0xc0170 added needs: review release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0 and removed needs: CI labels Dec 16, 2019
@0xc0170
Copy link
Contributor

0xc0170 commented Dec 16, 2019

@bulislaw please review

@adbridge
Copy link
Contributor

Re-running CI on this as it was last run 5 days ago

@mbed-ci
Copy link

mbed-ci commented Dec 18, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

@adbridge adbridge merged commit fb8bbb8 into ARMmbed:master Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bulislaw bulislaw bulislaw approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
BREAKING-CHANGE release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kjbracey @adbridge @mbed-ci @0xc0170 @bulislaw