Skip to content

Updates the Cypress WiFi Host Driver to 1.7.0 #12030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 6, 2019

Conversation

miteshdedhia7
Copy link

@miteshdedhia7 miteshdedhia7 commented Dec 4, 2019

Summary of changes

The changes are specific to the Cypress WiFi host driver and only impact specific network functionality for Cypress devices

  • Fixes issue with stopping AP in APSTA mode.
  • Removed an extra unused file left over from renaming TARGET_WHD to COMPONENT_WHD.

Impact of changes

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

CY8CKIT_062S2_43012-GCC_ARM.txt
CY8CPROTO_062_4343W-GCC_ARM.txt
CYW9P6S1_43438EVB_01-GCC_ARM.txt
CYW943012P6EVB_01-GCC_ARM.txt


Reviewers

@morser499 @maclobdell


@ciarmcom ciarmcom requested review from maclobdell and a team December 4, 2019 20:00
@ciarmcom
Copy link
Member

ciarmcom commented Dec 4, 2019

@miteshdedhia7, thank you for your changes.
@maclobdell @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 5, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Dec 5, 2019

Test run: FAILED

Summary: 1 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-IAR

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 5, 2019

@miteshdedhia7 Please review failures, look related to the changes

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 5, 2019

Compile [ 91.7%]: 4343WA1_clm_blob.c
[Error] 4343WA1_clm_blob.c@19,2: [Pe020]: identifier "location" is undefined
[Error] 4343WA1_clm_blob.c@19,2: [Pe018]: expected a ")"
[Error] 4343WA1_clm_blob.c@19,39: [Pe260]: explicit type is missing ("int" assumed)
[Error] 4343WA1_clm_blob.c@19,2: [Pe1113]: attributes are not permitted in a function definition
[Error] 4343WA1_clm_blob.c@19,2: [Pe141]: unnamed prototyped parameters not allowed when body is present
[Error] 4343WA1_clm_blob.c@21,6: [Pe130]: expected a "{"

Although I don't see this blob being changes here, restarting CI to confirm

@mbed-ci
Copy link

mbed-ci commented Dec 5, 2019

Test run: FAILED

Summary: 1 of 4 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-IAR

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 5, 2019

Please review failures

@miteshdedhia7
Copy link
Author

miteshdedhia7 commented Dec 5, 2019

Hi Martin (@0xc0170), the failure should be addressed. I also added another minor change to remove an unused file should not have any functional impact.

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 6, 2019

CI restarted

@mbed-ci
Copy link

mbed-ci commented Dec 6, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 3
Build artifacts

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 6, 2019

@adbridge Set to 5.15.0.rc2 as requested

@0xc0170 0xc0170 merged commit 0e66678 into ARMmbed:master Dec 6, 2019
@ifyall
Copy link

ifyall commented Dec 6, 2019

@adbridge, @0xc0170, @maclobdell and team, thank you very much for helping us get this important fix into 5.15!

Ian

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants