-
Notifications
You must be signed in to change notification settings - Fork 3k
Fix build errors for bare metal greentea tests on NRF52840_DK #12039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@evedon, thank you for your changes. |
@@ -1,12 +1,12 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rajkan01 Please fix your editor to remove trailing spaces by default
@evedon I set this for 5.15.0rc2 ? |
CI started |
Test run: SUCCESSSummary: 5 of 5 test jobs passed |
Discussed with @jamesbeyond We can put it in 5.15 to allow user to manually run greentea tests in bare metal mode for this target. |
@jamesbeyond @rajkan01 Please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary of changes
CI nightly tests are not building on NRF52840_DK with the following errors:
The solution is to fix the target override in baremetal.json which was wrongly removing USBDEVICE (similarly for EMAC).
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Covered by CI nightly tests.
Reviewers