Skip to content

Netsocket test adjusted to Wisun #12045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 19, 2019
Merged

Netsocket test adjusted to Wisun #12045

merged 1 commit into from
Dec 19, 2019

Conversation

tymoteuszblochmobica
Copy link
Contributor

@tymoteuszblochmobica tymoteuszblochmobica commented Dec 6, 2019 •
edited
Loading

Modifications needed to pass successfully netsocket tests under mesh Wisun.
Netsocket timeouts increased, TLS and app json also adjusted.

Summary of changes

Timeouts for netsocket tests increased to 25 minutes due to Wisun node join tekes currently even more than 10 min. Tests also takes some time so 20 min timeout is sometimes not enough.
Added custom app json for Wisun test missing fields and removing spurious ones based on wisun_s2lp mesh minimal example.
Fixed Wisun TLS config for successful CA cert and handshake.

Impact of changes

This impacts netsocket tests only

Migration actions required

No

Documentation

None

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[x] Tests / results supplied as part of this PR

Reviewers

@AnttiKauppila
@mikter
@JarkkoPaso
@michalpasztamobica
@SeppoTakalo

@ciarmcom
Copy link
Member

ciarmcom commented Dec 6, 2019

@tymoteuszblochmobica, thank you for your changes.
@JarkkoPaso @AnttiKauppila @mikter @michalpasztamobica @SeppoTakalo @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-test @ARMmbed/mbed-os-maintainers please review.

michalpasztamobica
michalpasztamobica approved these changes Dec 9, 2019
View reviewed changes
Copy link
Contributor

@michalpasztamobica michalpasztamobica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just a few minor comments.

TESTS/configs/wisun_S2LP.json Outdated
"macros":["MBEDTLS_USER_CONFIG_FILE=\"TESTS\\configs\\mbedtls_wisun_config.h\""],
"target_overrides": {
"*": {
"target.network-default-interface-type": "MESH",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

TESTS/configs/mbedtls_wisun_config.h Outdated
#undef MBEDTLS_MPI_MAX_SIZE
#define MBEDTLS_MPI_MAX_SIZE 256 // 256 bits is 32 bytes

/* Optimization. Remove all not needed stuff */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this should go a few lines below, where the "undef" part is starting?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

TESTS/configs/mbedtls_wisun_config.h Outdated
#define MBEDTLS_WISUN_CONFIG_H_

#define MBEDTLS_ENTROPY_MAX_SOURCES 20 // save 320 bytes of RAM (default is 20 entropy source)
#define MBEDTLS_SSL_MAX_CONTENT_LEN 8192 // Use 4kB buffers for input and output instead of 16kB
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment says "4kB", but the define is set to 8kB - which one is right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@tymoteuszblochmobica
Netsocket tests timeouts and JSON and TLS configuration adjusted to p…
0859ff7 
…ass under mesh Wisun.

Netsocket timeouts increased due to long node join on current Wisun implementation.
@0xc0170
Copy link
Contributor

0xc0170 commented Dec 16, 2019

Any more reviews from requested reviewers ?

@AnttiKauppila
Copy link

This is Wi-SUN related so @mikter should review this

mikter
mikter reviewed Dec 18, 2019
View reviewed changes
TESTS/netsocket/dns/dns_tests.h
static const int TESTS_TIMEOUT = 14 * 60;
#define MESH 3
#define WISUN 0x2345
#if MBED_CONF_TARGET_NETWORK_DEFAULT_INTERFACE_TYPE == MESH && MBED_CONF_NSAPI_DEFAULT_MESH_TYPE == WISUN
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

&lowPAN could have the same timeouts as they should have the same network formation times.

But This is also ok

@adbridge
Copy link
Contributor

CI started

@mbed-ci
Copy link

mbed-ci commented Dec 18, 2019

Test run: SUCCESS

Summary: 5 of 5 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0 and removed needs: CI labels Dec 19, 2019
@0xc0170 0xc0170 merged commit 9cd3813 into ARMmbed:master Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@mikter mikter mikter approved these changes

@michalpasztamobica michalpasztamobica michalpasztamobica approved these changes

@AnttiKauppila AnttiKauppila Awaiting requested review from AnttiKauppila

@JarkkoPaso JarkkoPaso Awaiting requested review from JarkkoPaso

@SeppoTakalo SeppoTakalo Awaiting requested review from SeppoTakalo

Assignees
No one assigned
Labels
release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@tymoteuszblochmobica @ciarmcom @0xc0170 @AnttiKauppila @adbridge @mbed-ci @mikter @michalpasztamobica