SharedPtr: add nullptr constructor #12048
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjbracey
added a commit
to kjbracey/mbed-os-5-docs
that referenced
this pull request
Dec 9, 2019
ARMmbed/mbed-os#12048 will require that `SharedPtr` users use `nullptr` rather than `NULL` or `0`, which will no longer compile. Update example in code. Change can be made to docs whenever, as `nullptr` form works now.
kjbracey
added a commit
to kjbracey/mbed-os-5-docs
that referenced
this pull request
Dec 9, 2019
ARMmbed/mbed-os#12048 will require that `SharedPtr` users use `nullptr` rather than `NULL` or `0`, which will no longer compile. Update example in code. Change can be made to docs whenever, as `nullptr` form works now.
kjbracey
added a commit
to kjbracey/mbed-os-5-docs
that referenced
this pull request
Dec 9, 2019
ARMmbed/mbed-os#12048 will require that `SharedPtr` users use `nullptr` rather than `NULL` or `0`, which will no longer compile. Update example in code. Change can be made to docs whenever, as `nullptr` form works now.
For consistency with `std::shared_ptr`, and `mbed::Callback`, and as a potential optimisation aid, give `SharedPtr` a distinct constructor for `nullptr`.
|
@kjbracey-arm, thank you for your changes. |
kjbracey
force-pushed
the
sharedptr_nullptr
branch
from
f14178b to
2b4b723
Compare
|
Looks good, but it's a breaking change. |
evedon
reviewed
Dec 13, 2019
| /** | ||
| * @brief Create empty SharedPtr not pointing to anything. | ||
| */ | ||
| constexpr SharedPtr(std::nullptr_t) : SharedPtr() |
There was a problem hiding this comment.
You could use constexpr to the default constructor as well.
There was a problem hiding this comment.
Indeed.
I'm doing that in #12037 - I've split the PRs cos this one is a breaking change, and that one isn't.
There was a problem hiding this comment.
And, actually, the constexpr here is ineffective until the default constructor it delegates to is made constexpr. But it's harmless if added alone.
evedon
approved these changes
Dec 16, 2019
0xc0170
added
release-version: 6.0.0-alpha-1
|
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
For consistency with
std::shared_ptr, andmbed::Callback, and as apotential optimisation aid, give
SharedPtra distinct constructor fornullptr.Impact of changes
nullptroverload.Migration actions required
nullptroverload meansSharedPtr(NULL)orSharedPtr(0)will no longer work; users must useSharedPtr(nullptr)orSharedPtr().Documentation
Docs example updated in ARMmbed/mbed-os-5-docs#1183
Pull request type
Test results
Reviewers