Skip to content

Greentea: Fix slice-calculation from kvstore test phase 2 #12056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

adbridge
Copy link
Contributor

@adbridge adbridge commented Dec 9, 2019

Summary of changes

This PR pulls in a single commit (Greentea: Fix slice-calculation from kvstore test phase 2) from Master which is required for 5.15 but the full PR from which it was originally added, is a feature one so cannot be taken.

Impact of changes

Migration actions required

Documentation

None

Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[ ] Feature update (New feature / Functionality change / New API)
[ ] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[ ] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[ ] Tests / results supplied as part of this PR

Reviewers


@adbridge
Copy link
Contributor Author

adbridge commented Dec 9, 2019

@SeppoTakalo @0xc0170 I have pulled this across directly to 5.15 as it is outside the capabilities of the release script and we need it before generating RC 2. Please review. It cannot be labelled with a release version as that would cause the script to try and pull it in again.

@adbridge
Copy link
Contributor Author

adbridge commented Dec 9, 2019

Required on mbed-os-5.15 by #12050

@adbridge
Copy link
Contributor Author

adbridge commented Dec 12, 2019

@0xc0170 This should have gone in before RC2. It looks like we may need to produce an RC3 after this and then #12050 is brought across.

@adbridge
Copy link
Contributor Author

CI started

@mbed-ci
Copy link

mbed-ci commented Dec 12, 2019

Test run: SUCCESS

Summary: 5 of 5 test jobs passed
Build number : 1
Build artifacts

@adbridge
Copy link
Contributor Author

Re-running ci to ensure no conflicts.

@mbed-ci
Copy link

mbed-ci commented Dec 16, 2019

Test run: SUCCESS

Summary: 5 of 5 test jobs passed
Build number : 2
Build artifacts

@adbridge
Copy link
Contributor Author

This is not a blocker and may only be reconsidered if we make a 5.15.1 and feel that the fix is required. Closing for now as the fix is on master

@adbridge adbridge closed this Dec 16, 2019
@0xc0170 0xc0170 deleted the storage_patch branch October 7, 2021 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants