Skip to content

Minimal Console: Use static pin map #12071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 11, 2019
Merged

Minimal Console: Use static pin map #12071

merged 1 commit into from
Dec 11, 2019

Conversation

hugueskamba
Copy link
Collaborator

@hugueskamba hugueskamba commented Dec 10, 2019 •
edited
Loading

Summary of changes

Extend the work done here.

Impact of changes

Migration actions required

Documentation

Pull request type 

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[X] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@mprse

@hugueskamba hugueskamba mentioned this pull request Dec 10, 2019
Merged
@ciarmcom ciarmcom requested review from mprse and a team December 10, 2019 16:00
@ciarmcom
Copy link
Member

@hugueskamba, thank you for your changes.
@mprse @ARMmbed/mbed-os-core @ARMmbed/mbed-os-maintainers please review.

mprse
mprse approved these changes Dec 11, 2019
View reviewed changes
Copy link
Contributor

@mprse mprse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
One minor thing is that the link in the description does not work.

@hugueskamba
Copy link
Collaborator Author

Looks good!
One minor thing is that the link in the description does not work.

Fixed.
Thanks

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 11, 2019

CI started

@0xc0170 0xc0170 added the release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0 label Dec 11, 2019
@mbed-ci
Copy link

mbed-ci commented Dec 11, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 removed the needs: CI label Dec 11, 2019
@0xc0170 0xc0170 merged commit 8c673ba into ARMmbed:master Dec 11, 2019
@hugueskamba hugueskamba deleted the hk_minimal_console_static_pinmap branch June 30, 2020 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@mprse mprse mprse approved these changes

Assignees
No one assigned
Labels
release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hugueskamba @ciarmcom @0xc0170 @mbed-ci @mprse