Skip to content

Unittest cleanup made #12080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2019
Merged

Unittest cleanup made #12080

merged 1 commit into from
Dec 11, 2019

Conversation

AnttiKauppila
Copy link

Summary of changes

Unittests cleanup made
CellularDevice still had the old way of defining built time defines and is now removed. Other unittests needed some minor fixes after this.

Impact of changes

Migration actions required

Documentation


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@ARMmbed/mbed-os-wan

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 11, 2019

Please extend the commit msg for Unittest cleanup made, including what is this cleanup (similar to description in the PR here).

@ciarmcom ciarmcom requested review from a team December 11, 2019 10:00
@ciarmcom
Copy link
Member

@AnttiKauppila, thank you for your changes.
@ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

CellularDevice still had the old way of defining built time defines and is now removed.
Other unittests needed some minor fixes after this.
@0xc0170
Copy link
Contributor

0xc0170 commented Dec 11, 2019

CI started meanwhile

@0xc0170 0xc0170 added the release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0 label Dec 11, 2019
@AnttiKauppila
Copy link
Author

commit msg updated

@mbed-ci
Copy link

mbed-ci commented Dec 11, 2019

Test run: SUCCESS

Summary: 1 of 1 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 8fd8ea2 into ARMmbed:master Dec 11, 2019
@AnttiKauppila AnttiKauppila deleted the ut_cleanup branch December 11, 2019 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants