Skip to content

TARGET_STM: add support of board NUCLEO_G071RB #12093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 19, 2019
Merged

TARGET_STM: add support of board NUCLEO_G071RB #12093

merged 4 commits into from
Dec 19, 2019

Conversation

ABOSTM
Copy link
Contributor

@ABOSTM ABOSTM commented Dec 12, 2019 •
edited
Loading

Summary of changes

Add support of board NUCLEO_G071RB:

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Test executed on STMicroelectronics test bench with toolchain: ARM, IAR and GCC_ARM
All MBED-OS tests PASSED.
All CI-Shield tests PASSED except 2 tests with GCC_ARM due to not enough space in FLASH
(tests-concurrent-comms and tests-concurrent-mixed).

@jeromecoutant
Copy link
Collaborator

@ARMmbed/team-st-mcd
@MarceloSalazar

jeromecoutant
jeromecoutant approved these changes Dec 12, 2019
View reviewed changes
Copy link
Collaborator

@jeromecoutant jeromecoutant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ST CI tests all OK!

@jeromecoutant jeromecoutant mentioned this pull request Dec 12, 2019
Closed
@ciarmcom ciarmcom requested review from a team December 12, 2019 16:00
@ciarmcom
Copy link
Member

@ABOSTM, thank you for your changes.
@ARMmbed/mbed-os-maintainers @ARMmbed/mbed-os-tools please review.

@jeromecoutant
Copy link
Collaborator

@0xc0170 @MarceloSalazar

From travis failure, there is -again- some issue with the arm pack manager file,
which doesn't contain latest chip information :-(

Got some information from @JanneKiiskila who tried once to update this pack json file,
but operations are very tricky....

Update CMSIS-pack info for STM32G-family
cec0547 
Update the CMSIS-pack info to `index.json` in arm_pack_manager -folder.
The update happens via python project.py --update-packs and a modified
version of the cmsis-pack-manager tool, which allows the download of
(most) CMSIS-pack files. The changes for this family ONLY are then updated
to the `index.json` -file.

Mbed OS PR ARMmbed#12093 need this change, as they refer to a target (device_name)
from the updated CMSIS-packs.

Ref: ARMmbed#12093
@JanneKiiskila
Copy link
Contributor

JanneKiiskila commented Dec 13, 2019 •
edited
Loading

Time for the rainbow unicorns again (oh, just got one)...

@JanneKiiskila JanneKiiskila mentioned this pull request Dec 13, 2019
Merged
@JanneKiiskila
Copy link
Contributor

JanneKiiskila commented Dec 13, 2019 •
edited
Loading

And here you go; ABOSTM#1
@ABOSTM - you need to merge that PR (If you think it's OKt) and then push your branch again to update this PR.

@JanneKiiskila
Copy link
Contributor

Are there some other CMSIS-pack updates that should be brought in (via separate PRs, of course)?

@jeromecoutant
Copy link
Collaborator

Are there some other CMSIS-pack updates that should be brought in (via separate PRs, of course)?

For me this should be done for all keil packages at each release for ex ?

@ABOSTM
Copy link
Contributor Author

ABOSTM commented Dec 13, 2019

Hi @JanneKiiskila , thanks for your help.
I took your commit. I updated targets.json accordingly, as well as IAR export.and tested the whole.
No other CMSIS-pack update for now.

@jeromecoutant
Copy link
Collaborator

Hi
Let's start CI for 5.15.1 ?
Thx

@mbed-ci
Copy link

mbed-ci commented Dec 19, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@adbridge adbridge merged commit bef36f5 into ARMmbed:master Dec 19, 2019
@bulislaw
Copy link
Member

Looks ok for the patch release.

0xc0170 pushed a commit to 0xc0170/mbed-os that referenced this pull request Jan 13, 2020
@0xc0170
Update CMSIS-pack info for STM32G-family
a1f7c96 
Update the CMSIS-pack info to `index.json` in arm_pack_manager -folder.
The update happens via python project.py --update-packs and a modified
version of the cmsis-pack-manager tool, which allows the download of
(most) CMSIS-pack files. The changes for this family ONLY are then updated
to the `index.json` -file.

Mbed OS PR ARMmbed#12093 need this change, as they refer to a target (device_name)
from the updated CMSIS-packs.

Ref: ARMmbed#12093
@mergify
Copy link

mergify bot commented Feb 4, 2020

This PR does not contain release version label after merging.

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 4, 2020

This PR does not contain release version label after merging.

There's PR fixing this, should be OK as will be reviewed for the version.

adbridge pushed a commit that referenced this pull request Feb 5, 2020
@adbridge
Update CMSIS-pack info for STM32G-family
ce3ab69 
Update the CMSIS-pack info to `index.json` in arm_pack_manager -folder.
The update happens via python project.py --update-packs and a modified
version of the cmsis-pack-manager tool, which allows the download of
(most) CMSIS-pack files. The changes for this family ONLY are then updated
to the `index.json` -file.

Mbed OS PR #12093 need this change, as they refer to a target (device_name)
from the updated CMSIS-packs.

Ref: #12093
RyoheiHagimoto pushed a commit to RyoheiHagimoto/mbed-os that referenced this pull request Mar 31, 2020
@RyoheiHagimoto
Update CMSIS-pack info for STM32G-family
99461f3 
Update the CMSIS-pack info to `index.json` in arm_pack_manager -folder.
The update happens via python project.py --update-packs and a modified
version of the cmsis-pack-manager tool, which allows the download of
(most) CMSIS-pack files. The changes for this family ONLY are then updated
to the `index.json` -file.

Mbed OS PR ARMmbed#12093 need this change, as they refer to a target (device_name)
from the updated CMSIS-packs.

Ref: ARMmbed#12093
@CRA-CNRS CRA-CNRS mentioned this pull request Nov 5, 2021
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bulislaw bulislaw bulislaw approved these changes

@jeromecoutant jeromecoutant jeromecoutant approved these changes

Assignees
No one assigned
Labels
release-version: 5.15.1 scope: new-target
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@ABOSTM @jeromecoutant @ciarmcom @JanneKiiskila @mbed-ci @bulislaw @0xc0170 @adbridge