Skip to content

Serial: Deprecate the class and promote UnbufferedSerial instead #12121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 19, 2019

Conversation

hugueskamba
Copy link
Collaborator

Summary of changes

Serial provides unbuffered I/O and is using blocking HAL calls. Deprecate the class and promote UnbufferedSerial as it is designed for an interrupt driven application or one that needs to have more control.

Impact of changes

Migration actions required

Documentation

https://github.com/ARMmbed/mbed-os/blob/master/docs/design-documents/drivers/serial/serial.md


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[X] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@evedon @kjbracey-arm @rajkan01


@ciarmcom ciarmcom requested review from evedon, kjbracey, rajkan01 and a team December 17, 2019 10:00
@ciarmcom
Copy link
Member

@hugueskamba, thank you for your changes.
@kjbracey-arm @rajkan01 @evedon @ARMmbed/mbed-os-core @ARMmbed/mbed-os-maintainers please review.

@hugueskamba hugueskamba force-pushed the hk-deprecate-serial-class branch from 9dcd787 to 1dc9c09 Compare December 17, 2019 14:23
@adbridge
Copy link
Contributor

For #6b8292d236147c82d21fceb77095d032f10ed238 could you please do a rebase and not a merge.

@hugueskamba hugueskamba force-pushed the hk-deprecate-serial-class branch from 6b8292d to 79054f1 Compare December 18, 2019 10:59
@hugueskamba
Copy link
Collaborator Author

hugueskamba commented Dec 18, 2019

For #6b8292d236147c82d21fceb77095d032f10ed238 could you please do a rebase and not a merge.

There was a GitHub merge conflict which was solved using GitHub.

This fixes the history.

@adbridge
Copy link
Contributor

CI started

@mbed-ci
Copy link

mbed-ci commented Dec 18, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@hugueskamba hugueskamba force-pushed the hk-deprecate-serial-class branch 2 times, most recently from 67e3168 to 79054f1 Compare December 18, 2019 14:47
@hugueskamba
Copy link
Collaborator Author

This force push restores the branch to the sha that was used to run the CI. There was an incorrect force push that changed it. The branch is ready to be merged.

@adbridge adbridge merged commit bad7baf into ARMmbed:master Dec 19, 2019
@adbridge adbridge added release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0 and removed ready for merge labels Dec 19, 2019
@hugueskamba hugueskamba deleted the hk-deprecate-serial-class branch June 30, 2020 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants