Cypress: Initial commit of SoftAP host tests. #12125

yarbcy · 2019-12-17T13:28:25Z

Cypress: Initial commit of SoftAP host tests. Applicable only for Cypress targets.

Summary of changes

Impact of changes

Cypress

Migration actions required

N/A

Documentation

Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[ ] Feature update (New feature / Functionality change / New API)
[ ] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[x] Tests / results supplied as part of this PR

target platform_name test suite test case passed failed result elapsed_time (sec)

CY8CPROTO_062_4343W-GCC_ARM CY8CPROTO_062_4343W tests-softap-ap Host OS Type Verification 1 0 OK 1.59

CY8CPROTO_062_4343W-GCC_ARM CY8CPROTO_062_4343W tests-softap-ap SoftAP test 1 0 OK 15.89

mbedgt: test case results: 2 OK

mbedgt: completed in 119.38 sec

target platform_name test suite test case passed failed result elapsed_time (sec)

CYW943012P6EVB_01-GCC_ARM CYW943012P6EVB_01 tests-softap-ap Host OS Type Verification 1 0 OK 1.55

CYW943012P6EVB_01-GCC_ARM CYW943012P6EVB_01 tests-softap-ap SoftAP test 1 0 OK 20.3

mbedgt: test case results: 2 OK

mbedgt: completed in 117.90 sec

target platform_name test suite test case passed failed result elapsed_time (sec)

CY8CKIT_062_WIFI_BT-GCC_ARM CY8CKIT_062_WIFI_BT tests-softap-ap Host OS Type Verification 1 0 OK 2.48

CY8CKIT_062_WIFI_BT-GCC_ARM CY8CKIT_062_WIFI_BT tests-softap-ap SoftAP test 1 0 OK 19.1

mbedgt: test case results: 2 OK

mbedgt: completed in 128.70 sec

Reviewers

Initial commit of SoftAP host tests See merge request repo/mbed-os!581

http://git-ore.aus.cypress.com/repo/bsp_csp/commit/9b800ca00964cf09be726a9d21538fe2063088e8

Applicable only for Cypress targets

ciarmcom · 2019-12-17T14:00:36Z

@yarbcy, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

yarbcy · 2019-12-18T08:53:25Z

@mprse @0xc0170 Please review.

yarbcy · 2019-12-19T12:32:31Z

@maclobdell Please review.

mprse · 2019-12-19T14:29:34Z

@yarbcy I'm not familiar with SoftAP.

yarbcy · 2019-12-19T17:11:50Z

@adbridge @mprse These tests are review internally. I expect from ARM team general comments about correctness place (folder) where those test are since they are applicable only for Cypress targets.

adbridge · 2019-12-19T17:14:47Z

@yarbcy could you please add a meaningful summary of changes, in the correct section .

adbridge · 2019-12-19T17:16:55Z

@jamesbeyond is there something else required to get these tests into our CI so they only run on Cypress targets ?

yarbcy · 2019-12-20T08:43:44Z

@jamesbeyond ?

adbridge · 2019-12-23T16:10:34Z

@jamesbeyond ?

@yarbcy it looks like most people have now gone away on Xmas break so we aren't going to see much movement I'm afraid.

jamesbeyond · 2019-12-30T12:16:10Z

Hi @yarbcy,
Sorry for the late reply. just got back from holiday.
Could you give us more info about this SoftAP. I don't think this is a feature that mbed-OS currently supports it.
If this is is a feature that only offered by Cypress through your own BSP/SDK, and other platforms are not supporting this. I'd suggest that if this test can be put into Cypress target folder rather than left this in a common TEST folder.

We have a previous case for SiliconLabs has their own spi tests : https://github.com/ARMmbed/mbed-os/tree/master/targets/TARGET_Silicon_Labs/TARGET_EFM32/TESTS

jamesbeyond · 2019-12-30T12:18:16Z

TESTS/softap/ap/main.cpp

+utest::v1::status_t greentea_test_setup(const size_t number_of_cases)
+{
+    // here, we specify the timeout (150) and the host runner (the name of our Python file)
+    GREENTEA_SETUP(150, "softap_basic");


I can see this test requires softap_basic host test but seems this python script is not part of this PR

0xc0170 · 2020-01-09T14:20:53Z

Based on the review above, this addition needs better description - what are these tests. Why are they only for Cypress (located in the TESTS, not under targets?) ?

yarbcy · 2020-01-10T18:08:37Z

Close this PR because of issue with commits. Comments are addresed in: #12240

Kyle Kearney and others added 15 commits September 6, 2019 16:36

Initial commit of SoftAP host tests

92c6e00

Merge branch 'kyle-softap-test' into 'pr-dev/softap-test'

82eda78

Initial commit of SoftAP host tests See merge request repo/mbed-os!581

Update template argument names to not collide with Arduino names

6f4e884

Merge branch 'master' into kyle-bsp-test

a1e5c6a

Merge branch 'master' into kyle-bsp-test

f141cbc

Merge commit '823d50d6' into kyle-bsp-test

b100759

MR is pending:

9f98a06

http://git-ore.aus.cypress.com/repo/bsp_csp/commit/9b800ca00964cf09be726a9d21538fe2063088e8

Merge branch 'master' into kyle-bsp-test

cd02017

Merge commit 'a79b1b3' into kyle-bsp-test

6eff658

Merge branch 'master' into kyle-bsp-test

0b237e1

Merge branch 'master' into pr-dev/softap-test

673eeb3

Merge tag 'cy-bsp-acceptance' into pr-dev/softap-test

d728701

Merge branch 'master' into kyle-bsp-test

d6ca071

Merge branch 'kyle-bsp-test' into pr-dev/softap-test

bd0a264

Cypress: Initial commit of SoftAP host tests.

fa9f777

Applicable only for Cypress targets

ciarmcom requested a review from a team December 17, 2019 14:00

ciarmcom added the needs: review label Dec 17, 2019

yarbcy added 2 commits December 17, 2019 16:02

Fix mbed astyle

d62f10c

Fix mbed astyle

f9dd2cd

adbridge requested a review from mprse December 18, 2019 15:27

adbridge requested a review from jamesbeyond December 19, 2019 17:16

jamesbeyond suggested changes Dec 30, 2019

View reviewed changes

0xc0170 added needs: work devices: cypress and removed needs: review labels Jan 2, 2020

yarbcy added 5 commits January 9, 2020 16:27

Addressed comments from ARM PR 12125

8229f53

Merge branch 'master' into pr/add-new-tests-softap

f58f5c2

Merge from kyle-bsp-test

a1f3d57

Fix folders structure for SoftAP tests

983f32c

Merge from softap-test br

cee56b7

yarbcy closed this Jan 10, 2020

yarbcy mentioned this pull request Jan 10, 2020

Cypress: add SoftAP host tests #12240

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Cypress: Initial commit of SoftAP host tests. #12125

Cypress: Initial commit of SoftAP host tests. #12125

Uh oh!

yarbcy commented Dec 17, 2019 •

edited

Loading

Uh oh!

ciarmcom commented Dec 17, 2019

Uh oh!

yarbcy commented Dec 18, 2019

Uh oh!

yarbcy commented Dec 19, 2019

Uh oh!

mprse commented Dec 19, 2019

Uh oh!

yarbcy commented Dec 19, 2019

Uh oh!

adbridge commented Dec 19, 2019

Uh oh!

adbridge commented Dec 19, 2019

Uh oh!

yarbcy commented Dec 20, 2019

Uh oh!

adbridge commented Dec 23, 2019

Uh oh!

jamesbeyond commented Dec 30, 2019

Uh oh!

jamesbeyond Dec 30, 2019 •

edited

Loading

Uh oh!

0xc0170 commented Jan 9, 2020

Uh oh!

yarbcy commented Jan 10, 2020

Uh oh!

Uh oh!

target	platform_name	test suite	test case	passed	failed	result	elapsed_time (sec)
CY8CPROTO_062_4343W-GCC_ARM	CY8CPROTO_062_4343W	tests-softap-ap	Host OS Type Verification	1	0	OK	1.59
CY8CPROTO_062_4343W-GCC_ARM	CY8CPROTO_062_4343W	tests-softap-ap	SoftAP test	1	0	OK	15.89
mbedgt: test case results: 2 OK
mbedgt: completed in 119.38 sec

target	platform_name	test suite	test case	passed	failed	result	elapsed_time (sec)
CYW943012P6EVB_01-GCC_ARM	CYW943012P6EVB_01	tests-softap-ap	Host OS Type Verification	1	0	OK	1.55
CYW943012P6EVB_01-GCC_ARM	CYW943012P6EVB_01	tests-softap-ap	SoftAP test	1	0	OK	20.3
mbedgt: test case results: 2 OK
mbedgt: completed in 117.90 sec

target	platform_name	test suite	test case	passed	failed	result	elapsed_time (sec)
CY8CKIT_062_WIFI_BT-GCC_ARM	CY8CKIT_062_WIFI_BT	tests-softap-ap	Host OS Type Verification	1	0	OK	2.48
CY8CKIT_062_WIFI_BT-GCC_ARM	CY8CKIT_062_WIFI_BT	tests-softap-ap	SoftAP test	1	0	OK	19.1
mbedgt: test case results: 2 OK
mbedgt: completed in 128.70 sec

Cypress: Initial commit of SoftAP host tests. #12125

Cypress: Initial commit of SoftAP host tests. #12125

Uh oh!

Conversation

yarbcy commented Dec 17, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of changes

Impact of changes

Migration actions required

Documentation

Pull request type

Test results

Reviewers

Uh oh!

ciarmcom commented Dec 17, 2019

Uh oh!

yarbcy commented Dec 18, 2019

Uh oh!

yarbcy commented Dec 19, 2019

Uh oh!

mprse commented Dec 19, 2019

Uh oh!

yarbcy commented Dec 19, 2019

Uh oh!

adbridge commented Dec 19, 2019

Uh oh!

adbridge commented Dec 19, 2019

Uh oh!

yarbcy commented Dec 20, 2019

Uh oh!

adbridge commented Dec 23, 2019

Uh oh!

jamesbeyond commented Dec 30, 2019

Uh oh!

jamesbeyond Dec 30, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented Jan 9, 2020

Uh oh!

yarbcy commented Jan 10, 2020

Uh oh!

Uh oh!

yarbcy commented Dec 17, 2019 •

edited

Loading

jamesbeyond Dec 30, 2019 •

edited

Loading