-
Notifications
You must be signed in to change notification settings - Fork 3k
cordio nrf: Add timer shutdown after time stop on deinit #12136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@BramdeBoer1, thank you for your changes. |
@BramdeBoer1 you seem to have deleted part of the PR template. Could you please restore it as in the future the sections will be automatically parsed. Also could you please complete the testing section? Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok to me
@pan- could you take a quick look please ? |
Restored the missing PR template parts. |
@BramdeBoer1 thanks. We will probably have to wait for the PAN team to comment then. Though most people are now on Xmas break. |
@ARMmbed/mbed-os-pan could you please review |
Travis had a problem to report a status,I 'll reopen this PR. It should help |
@BramdeBoer1 Travis is having an issue to pick up this PR. I could not find it there in the history. The quickest could be - just amend the last commit to only change sha - no changes and push force. It fixes it often. |
@0xc0170 done |
Thanks @BramdeBoer1 . Travis is playing with us, it could not pick this up :/ Can you send a new PR completely. I don't think there is any other way. It happened previously and we just recreated a PR. Sorry for the inconvenience. |
Summary of changes
This is a fix for issue #12127
This pull requests decreases the power consumption by 20uA after ble shutdown on the nrf52840 when using the cordio stack.
Impact of changes
Migration actions required
Documentation
None
Pull request type
Test results
Reviewers