Skip to content

cordio nrf: Add timer shutdown after time stop on deinit #12136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

BramdeBoer1
Copy link
Contributor

@BramdeBoer1 BramdeBoer1 commented Dec 19, 2019

Summary of changes

This is a fix for issue #12127
This pull requests decreases the power consumption by 20uA after ble shutdown on the nrf52840 when using the cordio stack.

Impact of changes

Migration actions required

Documentation

None


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@ciarmcom ciarmcom requested review from a team December 19, 2019 08:00
@ciarmcom
Copy link
Member

@BramdeBoer1, thank you for your changes.
@ARMmbed/mbed-os-pan @ARMmbed/mbed-os-maintainers please review.

@adbridge
Copy link
Contributor

@BramdeBoer1 you seem to have deleted part of the PR template. Could you please restore it as in the future the sections will be automatically parsed. Also could you please complete the testing section? Thanks.

Copy link
Contributor

@adbridge adbridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me

@adbridge
Copy link
Contributor

@pan- could you take a quick look please ?

@BramdeBoer1
Copy link
Contributor Author

Restored the missing PR template parts.
I am however not quite sure about the testing part as i couldn't find an existing test for the nrf52840 cordio stack

@adbridge
Copy link
Contributor

Restored the missing PR template parts.
I am however not quite sure about the testing part as i couldn't find an existing test for the nrf52840 cordio stack

@BramdeBoer1 thanks. We will probably have to wait for the PAN team to comment then. Though most people are now on Xmas break.

@0xc0170 0xc0170 added the release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0 label Jan 3, 2020
@0xc0170 0xc0170 changed the title Added timer shutdown after time stop on deinit nrf: Add timer shutdown after time stop on deinit Jan 3, 2020
@0xc0170 0xc0170 changed the title nrf: Add timer shutdown after time stop on deinit cordio nrf: Add timer shutdown after time stop on deinit Jan 3, 2020
@adbridge
Copy link
Contributor

adbridge commented Jan 6, 2020

@ARMmbed/mbed-os-pan could you please review

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 8, 2020

cc @desmond-blue

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 8, 2020

Travis had a problem to report a status,I 'll reopen this PR. It should help

@0xc0170 0xc0170 closed this Jan 8, 2020
@0xc0170 0xc0170 reopened this Jan 8, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Jan 8, 2020

@BramdeBoer1 Travis is having an issue to pick up this PR. I could not find it there in the history.

The quickest could be - just amend the last commit to only change sha - no changes and push force. It fixes it often.

@BramdeBoer1
Copy link
Contributor Author

@0xc0170 done

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 9, 2020

Thanks @BramdeBoer1 . Travis is playing with us, it could not pick this up :/ Can you send a new PR completely. I don't think there is any other way. It happened previously and we just recreated a PR. Sorry for the inconvenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants