Skip to content

Bare metal: Enabling the watchdog green tea test #12183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

rajkan01
Copy link
Contributor

@rajkan01 rajkan01 commented Jan 2, 2020

Summary of changes

To include the watchdog, watchdog_reset green tea test for bare metal. Build and run the test will be possible after this PR is merged.

Impact of changes

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@evedon @jamesbeyond


@ciarmcom ciarmcom requested review from evedon, jamesbeyond and a team January 2, 2020 18:00
@ciarmcom
Copy link
Member

ciarmcom commented Jan 2, 2020

@rajkan01, thank you for your changes.
@jamesbeyond @evedon @ARMmbed/mbed-os-hal @ARMmbed/mbed-os-core @ARMmbed/mbed-os-test @ARMmbed/mbed-os-maintainers please review.

Copy link
Contributor

@mprse mprse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this one be closed when we got PR #12182?

As far as I understand this PR disables watchdog tests for bare metal profile and PR #12182 makes them bare metal ready.

@fkjagodzinski
Copy link
Member

@mprse, correct, the #12182 removes the RTOS dependency from the watchdog tests so these can run with a bare-metal profile. This PR removes a NOT SUPPORTED error for bare-metal; without this patch the tests will be skipped. Actually, both patches could have been combined into one PR.

@rajkan01
Copy link
Contributor Author

rajkan01 commented Jan 3, 2020

This PR changes can be merged with PR#12182, so closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants