-
Notifications
You must be signed in to change notification settings - Fork 3k
BLE: fix pointer not set to null on delete #12185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@AGlass0fMilk Should we close #12145 ? Please review |
@paul-szczepanek-arm, thank you for your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Were there still tabs in my original PR? 🤣
This seems to be missing the removal of the "double delete" that could occur upon SM reset:
Now it'll just be trying to delete a NULL pointer.
checking a pointer for NULL is redundant in application code, the check is already performed inside delete |
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
@AGlass0fMilk This is ready for integration. All good here? |
If that’s the case it should be all set. |
Summary of changes
Fix missing setting of pointer to NULL on delete.
Impact of changes
Migration actions required
Documentation
Based on @AGlass0fMilk PR #12145, superseding it.
Pull request type
Test results
Reviewers