Skip to content

Nanostack Socket event handler fix #12194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 7, 2020
Merged

Conversation

juhhei01
Copy link
Contributor

@juhhei01 juhhei01 commented Jan 7, 2020

SOCKET_TX_DONE not generate event signal anymore for SOCKET_MODE_DATAGRAM.
Event handler try to read socket which is not necessary in that case.

Summary of changes

SOCKET_MODE_DATAGRAM nano stack SOCKET_TX_DONE can be suppress.

Impact of changes

None.

Migration actions required

None.

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@teetak01 @kjbracey-arm @mikter @JarkkoPaso


SOCKET_TX_DONE not generate event signal anymore for SOCKET_MODE_DATAGRAM.
Event handler try to read socket which is not necessary in that case.
@juhhei01
Copy link
Contributor Author

juhhei01 commented Jan 7, 2020

@kjbracey-arm @SeppoTakalo @mikter @JarkkoPaso Please review.

Copy link
Contributor

@kjbracey kjbracey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also remove the debug trace for the datagram case? Probably no point in logging something we're choosing to ignore.

What do others think?

EDIT: Although I note we are printing log on every single event code, including others we ignore, so doing so for this is at least consistent. If trimming this, probably should trim others.

@mbed-ci
Copy link

mbed-ci commented Jan 7, 2020

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added needs: CI release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0 and removed needs: CI labels Jan 7, 2020
@0xc0170 0xc0170 merged commit e666848 into ARMmbed:master Jan 7, 2020
@juhhei01 juhhei01 deleted the socket_api_fix branch January 7, 2020 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants