Skip to content

TARGET_STM: FW driver files refactor proposition #12201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jan 15, 2020

Conversation

jeromecoutant
Copy link
Collaborator

Summary of changes

Hi

In order to make easier driver files maintenance for ST Cube delivery,
And to help each customer to develop his own board with a different chip as the one used for NUCLEO (ST board),
I tried to simplify and improve the procedure of the copy from Cube FW delivery to mbed-os github.

I started with the STM32G0 family which doesn’t impact many customer yet.
Goal is to use scripts for coming STM32G4 and STM32L5, and then for all families.

What has changed:

  • in the family level (targets/TARGET_STM/TARGET_STM32G0/), “device” name is renamed into STM32Cube_FW
    => I think it is more explicit

Then in order to make it again more explicit, I propose to copy:

  • files from STM32Cube_FW_G0_Vx.x.x\Drivers\CMSIS (ST Cube FW delivery) to TARGET_STM32G0\STM32Cube_FW\CMSIS
  • files from STM32Cube_FW_G0_Vx.x.x\Drivers\STM32G0xx_HAL_Driver to TARGET_STM32G0\STM32Cube_FW\STM32G0xx_HAL_Driver
  • what ST Cube FW calls "template" files to TARGET_STM32G0\STM32Cube_FW

Now on the the sub family level (targets/TARGET_STM/TARGET_STM32G0/TARGET_STM32G0XXxx)

  • Previously, only the sub family needed by the ported target MCU was created
    ==>Now all sub families are automatically created, customers only have to create their own target inside

  • “device” directory was not used and then removed

  • all TOOLCHAIN_xxx files are available (aligned with https://os.mbed.com/docs/mbed-os/v5.14/porting/porting-bootstrap.html) for all sub families

Conclusion:

Impact of changes

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@ARMmbed/team-st-mcd
@MarceloSalazar @bulislaw @0xc0170


@ciarmcom ciarmcom requested review from 0xc0170, bulislaw, MarceloSalazar and a team January 7, 2020 18:00
@ciarmcom
Copy link
Member

ciarmcom commented Jan 7, 2020

@jeromecoutant, thank you for your changes.
@bulislaw @0xc0170 @MarceloSalazar @ARMmbed/mbed-os-maintainers please review.

@0xc0170 0xc0170 changed the title [TARGET_STM] FW driver files refactor proposition TARGET_STM: FW driver files refactor proposition Jan 8, 2020
@0Grit
Copy link

0Grit commented Jan 8, 2020

@ARMmbed/team-embeddedplanet

@MarceloSalazar
Copy link

Just a friendly reminder for @ARMmbed/mbed-os-maintainers to review ;-)

Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question: commit 57f144e removes 2 SDPX identifiers. I assume this is because drivers do not provide this neither (was actually just in Mbed OS) ? It would be nice if they have SDPX identifiers as well (would help with checking licenses).

The rest looks fine to me

@jeromecoutant
Copy link
Collaborator Author

I assume this is because drivers do not provide this neither

Yes, files in STM32Cube_FW are the one from ST Cube delivery. No change.

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 10, 2020

I scheduled CI

@mbed-ci
Copy link

mbed-ci commented Jan 10, 2020

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 978a966 into ARMmbed:master Jan 15, 2020
@jeromecoutant jeromecoutant deleted the PR_G0REFACTOR branch January 29, 2020 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants