-
Notifications
You must be signed in to change notification settings - Fork 3k
TARGET_STM: FW driver files refactor proposition #12201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Goal is to remove all mis-aligment with official ST CUBE delivery
@jeromecoutant, thank you for your changes. |
@ARMmbed/team-embeddedplanet |
Just a friendly reminder for @ARMmbed/mbed-os-maintainers to review ;-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question: commit 57f144e removes 2 SDPX identifiers. I assume this is because drivers do not provide this neither (was actually just in Mbed OS) ? It would be nice if they have SDPX identifiers as well (would help with checking licenses).
The rest looks fine to me
Yes, files in STM32Cube_FW are the one from ST Cube delivery. No change. |
I scheduled CI |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Summary of changes
Hi
In order to make easier driver files maintenance for ST Cube delivery,
And to help each customer to develop his own board with a different chip as the one used for NUCLEO (ST board),
I tried to simplify and improve the procedure of the copy from Cube FW delivery to mbed-os github.
I started with the STM32G0 family which doesn’t impact many customer yet.
Goal is to use scripts for coming STM32G4 and STM32L5, and then for all families.
What has changed:
=> I think it is more explicit
Then in order to make it again more explicit, I propose to copy:
Now on the the sub family level (targets/TARGET_STM/TARGET_STM32G0/TARGET_STM32G0XXxx)
Previously, only the sub family needed by the ported target MCU was created
==>Now all sub families are automatically created, customers only have to create their own target inside
“device” directory was not used and then removed
all TOOLCHAIN_xxx files are available (aligned with https://os.mbed.com/docs/mbed-os/v5.14/porting/porting-bootstrap.html) for all sub families
Conclusion:
https://github.com/ARMmbed/mbed-os/blob/master/tools/targets/STM32_gen_PeripheralPins.py
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Reviewers
@ARMmbed/team-st-mcd
@MarceloSalazar @bulislaw @0xc0170