Skip to content

Increase MSI clock frequency when exiting deep sleep #12202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2020

Conversation

LMESTM
Copy link
Contributor

@LMESTM LMESTM commented Jan 7, 2020

Summary of changes

This will optimize down the time it takes to restore the clock
settings when getting out of deep sleep.

If 48MHz is available let's use it, otherwise at least 4MHz should be
available for any MCU with MSI.

Fixes #12116

Impact of changes

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[x] Tests / results supplied as part of this PR

ST non regression test suite RUN and PASS.

Reviewers

@jeromecoutant


This will optimize down the time it takes to restore the clock
settings when getting out of deep sleep.

If 48MHz is available let's use it, otherwise at least 4MHz should be
available for any MCU with MSI.
@ciarmcom
Copy link
Member

ciarmcom commented Jan 7, 2020

@LMESTM, thank you for your changes.
@jeromecoutant @ARMmbed/mbed-os-maintainers please review.

Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the implications, besides getting the time down? power consumption?

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 8, 2020

I started CI meanwhile

@LMESTM
Copy link
Contributor Author

LMESTM commented Jan 8, 2020

What are the implications, besides getting the time down? power consumption?

This is a temporary state only - this will save time in wake-up and in the end allow spending more time in low power.

@0Grit
Copy link

0Grit commented Jan 8, 2020

+1 for this. Normally this sort of effort falls to me and our team to optimize.

@mbed-ci
Copy link

mbed-ci commented Jan 8, 2020

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0 and removed needs: review labels Jan 9, 2020
@0xc0170 0xc0170 merged commit dbb0695 into ARMmbed:master Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NUCLEO_L073RZ: wake up from deep sleep test fails when linking with microlib
6 participants