Fix for issue #10725: disable lp-ticker for STM targets which uses RTC/LSI for lp-ticker #12210

mprse · 2020-01-08T09:42:44Z

Summary of changes

This PR is continuation of PR #12135 - which will be closed.

tests-mbed_drivers-lp_timer is failing on UBLOX_C030_U201 (can't reproduce the failure locally).

According to the documentation of STM32F437VG76 MCU:

The LSI RC acts as an low-power clock source that can be kept running in Stop and
Standby mode for the independent watchdog (IWDG) and Auto-wakeup unit (AWU). The
clock frequency is around 32 kHz. For more details, refer to the electrical characteristics
section of the datasheets.

It seems that typical LSI frequency is 32 kHz, but it may vary from 17 to 47 kHz!
This means that lp-timer test may fail on the same board because lp-ticker frequency is unstable.

The proposition is to disable lp-ticker for STM targets which uses RTC/LSI to drive lp-ticker - LSI is unstable and breaks accuracy requirements for low power ticker.

Impact of changes

Migration actions required

Documentation

Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@jeromecoutant

ciarmcom · 2020-01-08T10:00:47Z

@mprse, thank you for your changes.
@jeromecoutant @ARMmbed/mbed-os-maintainers please review.

jeromecoutant · 2020-01-08T10:03:03Z

Should be approved by UBLOX team

0xc0170 · 2020-01-08T10:45:43Z

@ARMmbed/team-ublox Please review

0xc0170

Assuming there is no fallback option for these targets. @ARMmbed/team-ublox to confirm.

fahimalavi · 2020-01-08T12:44:46Z

Several of C030 targets has LSE available(including C030-U201 and C030-R412M). Why don't you use LSE instead disabling for all C030s ?
We know some users who are using LPTicker and LSE using C030.

mprse · 2020-01-08T13:13:10Z

@fahim-ublox If there is another better solution that can be used then let's use it.

This solution was agreed in PR #12135 and the problem was analyzed in the following issue #10725 (comment).

Can you provide some details on how to use LSE on UBLOX target? Simply remove "overrides": { "lse_available": 0 } from targets.json?

mprse · 2020-01-09T12:01:04Z

@fahim-ublox Can you review?

I enabled lp-ticker driven by LSE for UBLOX C030 family. Tested this locally and on RAAS (where some problems with the lp-timer test were detected). In both cases test is passing regularly.

fahimalavi · 2020-01-09T12:08:54Z

There are some old C030 board those have no LSE available. So to keep them happy as well idea was to keep LSE available to zero in target.json and override in platform tests json or relevant applications. i.e.
We are using something like
echo {"target_overrides": {"*": {"lwip.ppp-enabled": true, "target.lse_available": 1}}}>mbed_app.json

mprse · 2020-01-09T12:53:17Z

There are some old C030 board those have no LSE available. So to keep them happy as well idea was to keep LSE available to zero in target.json and override in platform tests json or relevant applications.

Can you provide for which targets LSE can be enabled?

fahimalavi · 2020-01-10T05:34:05Z

I checked locally the boards you should have come from the first production run so if your boards support an external oscillator then any of the ones that could get to a customer will also support it. So we think if you marked lse available, it’s probably fine.

mprse · 2020-01-10T11:02:12Z

I checked locally the boards you should have come from the first production run so if your boards support an external oscillator then any of the ones that could get to a customer will also support it. So we think if you marked lse available, it’s probably fine.

Thank you @fahim-ublox .
If you are happy with the current version please pass the review.

0xc0170 · 2020-01-10T14:43:11Z

CI started

mbed-ci · 2020-01-10T15:30:10Z

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-ARM
jenkins-ci/mbed-os-ci_build-IAR
jenkins-ci/mbed-os-ci_build-GCC_ARM

mprse · 2020-01-13T08:11:28Z

Test run: FAILED

Disabled BLE feature for targets without lp-ticker.

0xc0170 · 2020-01-13T08:52:04Z

@mprse I don't see any new commit here, should it be?

mprse · 2020-01-13T08:59:51Z

@mprse I don't see any new commit here, should it be?

Thanks @0xc0170 . Something went wrong while pushing. It should be good now.

jeromecoutant · 2020-01-13T09:07:23Z

Disabled BLE feature for targets without lp-ticker.

Maybe this constraint should be added in BLE mbed_lib json ?

0xc0170 · 2020-01-13T09:39:34Z

CI restarted

0xc0170 · 2020-01-13T09:40:23Z

Disable comment should contain a reason for disabling. Please add, let CI to complete now to check the update.

mbed-ci · 2020-01-20T15:40:32Z

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 3
Build artifacts

Pull request has been modified.

mprse · 2020-01-21T08:21:10Z

I fixed the styling manually. Hopefully, it's ok now.

bulislaw · 2020-01-21T16:24:27Z

Does it still needs work? It seems it was fixed.

mprse · 2020-01-21T16:33:38Z

It needs Ci.

adbridge · 2020-01-22T17:18:50Z

CI started

mbed-ci · 2020-01-22T18:17:32Z

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 4
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_greentea-test

mprse · 2020-01-23T06:46:17Z

Test run: FAILED

@0xc0170 It looks like all passed.

adbridge · 2020-01-23T12:19:46Z

Test run: FAILED

@0xc0170 It looks like all passed.

Looks like another CI hiccup. Will re-run the ci and hopefully it will work this time.

mbed-ci · 2020-01-23T13:17:43Z

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 5
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_dynamic-memory-usage

mprse · 2020-01-23T13:33:59Z

Looks like another CI hiccup. Will re-run the ci and hopefully it will work this time.\

@adbridge
Now jenkins-ci/greentea-test passed, but jenkins-ci/dynamic-memory-usage failed 😢 .

adbridge · 2020-01-23T17:03:14Z

Will try running again although interestingly another PR failed the dynamic-memory-usage as well earlier so there may be a problem

adbridge · 2020-01-23T17:06:40Z

CI started

mbed-ci · 2020-01-23T17:57:42Z

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 6
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_dynamic-memory-usage

mprse mentioned this pull request Jan 8, 2020

Fix for issue #10725 (tests-mbed_drivers-lp_timer failing nightly) #12135

Closed

ciarmcom requested review from jeromecoutant and a team January 8, 2020 10:00

ciarmcom added the needs: review label Jan 8, 2020

0xc0170 requested a review from a team January 8, 2020 10:45

0xc0170 approved these changes Jan 8, 2020

View reviewed changes

0xc0170 added needs: work and removed needs: review labels Jan 8, 2020

fahimalavi approved these changes Jan 10, 2020

View reviewed changes

0xc0170 added needs: CI and removed needs: work labels Jan 10, 2020

0xc0170 self-requested a review January 13, 2020 09:40

0xc0170 added the needs: work label Jan 20, 2020

targets.json: fix styling

3980911

adbridge added needs: CI release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0 and removed needs: work labels Jan 22, 2020

adbridge requested a review from 0xc0170 January 23, 2020 12:22

adbridge approved these changes Jan 23, 2020

View reviewed changes

mergify bot added ready for merge and removed needs: CI labels Jan 23, 2020

adbridge added needs: CI and removed ready for merge labels Jan 23, 2020

mergify bot added ready for merge and removed needs: CI labels Jan 23, 2020

adbridge merged commit 6e762a2 into ARMmbed:master Jan 24, 2020

adbridge removed the ready for merge label Jan 24, 2020

Fix for issue #10725: disable lp-ticker for STM targets which uses RTC/LSI for lp-ticker #12210

Fix for issue #10725: disable lp-ticker for STM targets which uses RTC/LSI for lp-ticker #12210

Uh oh!

Conversation

mprse commented Jan 8, 2020

Summary of changes

Impact of changes

Migration actions required

Documentation

Pull request type

Test results

Reviewers

Uh oh!

ciarmcom commented Jan 8, 2020

Uh oh!

jeromecoutant commented Jan 8, 2020

Uh oh!

0xc0170 commented Jan 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0xc0170 left a comment

Choose a reason for hiding this comment

Uh oh!

fahimalavi commented Jan 8, 2020

Uh oh!

mprse commented Jan 8, 2020

Uh oh!

mprse commented Jan 9, 2020

Uh oh!

fahimalavi commented Jan 9, 2020

Uh oh!

mprse commented Jan 9, 2020

Uh oh!

fahimalavi commented Jan 10, 2020

Uh oh!

mprse commented Jan 10, 2020

Uh oh!

0xc0170 commented Jan 10, 2020

Uh oh!

mbed-ci commented Jan 10, 2020

Test run: FAILED

Uh oh!

mprse commented Jan 13, 2020

Uh oh!

0xc0170 commented Jan 13, 2020

Uh oh!

mprse commented Jan 13, 2020

Uh oh!

jeromecoutant commented Jan 13, 2020

Uh oh!

0xc0170 commented Jan 13, 2020

Uh oh!

0xc0170 commented Jan 13, 2020

Uh oh!

mbed-ci commented Jan 20, 2020

Test run: SUCCESS

Uh oh!

mprse commented Jan 21, 2020

Uh oh!

bulislaw commented Jan 21, 2020

Uh oh!

mprse commented Jan 21, 2020

Uh oh!

adbridge commented Jan 22, 2020

Uh oh!

mbed-ci commented Jan 22, 2020

Test run: FAILED

Uh oh!

mprse commented Jan 23, 2020

Uh oh!

adbridge commented Jan 23, 2020

Uh oh!

mbed-ci commented Jan 23, 2020

Test run: FAILED

Uh oh!

mprse commented Jan 23, 2020

Uh oh!

adbridge commented Jan 23, 2020

Uh oh!

adbridge commented Jan 23, 2020

0xc0170 commented Jan 8, 2020 •

edited

Loading