Cellular: Move string_to_pdp_type method to CellularContext #12214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
string_to_pdp_type is only used in CellularContext classes and by having the conversion method in CellularContext it can be used to check also the non-standard Non-IP PDP type string.
AriParkkila
approved these changes
Jan 8, 2020
|
@kivaisan, thank you for your changes. |
0xc0170
approved these changes
Jan 8, 2020
|
CI started |
AriParkkila
approved these changes
Jan 8, 2020
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
0xc0170
added
release-version: 6.0.0-alpha-1
|
@kivaisan Could you please fill in the 'Impact of Changes' and the 'Documentation' sections as these will be used in the release notes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
string_to_pdp_typeis only used inCellularContextclasses and by having the conversion method in CellularContext it can be used also to check the non-standard Non-IP PDP type string.Impact of changes
None, if application uses existing cellular classes. If user has implemented own
CellularContextclass, then see migration actions required.Migration actions required
Classes deriving from
CellularContextmust implement new function:virtual const char *get_nonip_context_type_str() = 0;This API has already been implemented in AT_CellularContext though, so current code does not change.
Documentation
None
Pull request type
Test results
Reviewers
@ARMmbed/mbed-os-wan