Skip to content

Need RAM and ROM size for compilation #12228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 23, 2020

Conversation

jeromecoutant
Copy link
Collaborator

Summary of changes

Previously ROM and RAM sizes comes as linker predefine during mbed build.

Confirmed by:
Looking at https://os.mbed.com/docs/mbed-os/v5.14/porting/porting-bootstrap.html
/* Tools provide -DMBED_ROM_START=xxx -DMBED_ROM_SIZE=xxx -DMBED_RAM_START=xxx -DMBED_RAM_SIZE=xxx */

1 commit is reverted in order to get the expected behavior.

Thx

Impact of changes

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@ciarmcom ciarmcom requested review from a team January 9, 2020 18:00
@ciarmcom
Copy link
Member

ciarmcom commented Jan 9, 2020

@jeromecoutant, thank you for your changes.
@ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

100755 → 100644

Please revert file attributes change

@jeromecoutant
Copy link
Collaborator Author

Please revert file attributes change

done

@0xc0170 0xc0170 self-requested a review January 13, 2020 09:54
@0xc0170
Copy link
Contributor

0xc0170 commented Jan 13, 2020

@jeromecoutant Trying to understand for this revert. Can you add a reason to the commit msg (what is actual behavior, that is causing a problem) and how it fixes it ?

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 13, 2020

Previously ROM and RAM sizes comes as linker predefine during mbed build.

Is this true? If bootloader is not supported, does a target have defined rom/ram sizes ? This could be one of the things I am not completely certain how this information is connected to bootloader (if it actually is).

@jeromecoutant
Copy link
Collaborator Author

@jeromecoutant Trying to understand for this revert. Can you add a reason to the commit msg (what is actual behavior, that is causing a problem) and how it fixes it ?

As indicated in the description:
https://os.mbed.com/docs/mbed-os/v5.14/porting/porting-bootstrap.html
/* Tools provide -DMBED_ROM_START=xxx -DMBED_ROM_SIZE=xxx -DMBED_RAM_START=xxx -DMBED_RAM_SIZE=xxx */

@jeromecoutant
Copy link
Collaborator Author

Is this true? If bootloader is not supported, does a target have defined rom/ram sizes ?

Region sizes doesn't come from bootloader info, they comes from pack manager tool.

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 17, 2020

Yes from the manager but they are used/defined only if bootloder is there? My assumption might be wrong, thus asking .

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 17, 2020

@ARMmbed/mbed-os-tools Please review

I'll run CI meanwhile

@mbed-ci
Copy link

mbed-ci commented Jan 17, 2020

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_cloud-client-pytest

@jeromecoutant
Copy link
Collaborator Author

Yes from the manager but they are used/defined only if bootloder is there? My assumption might be wrong, thus asking .

I would like to have some "generic" linker scripts. So having these region values helps.

@adbridge
Copy link
Contributor

NOTE the ci last ran several days ago and thus this will need to be run again before it can be merged, to ensure no conflicts etc due to other merges in the interim!

@adbridge
Copy link
Contributor

CI restarted

@mbed-ci
Copy link

mbed-ci commented Jan 22, 2020

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

@mergify mergify bot removed the needs: CI label Jan 22, 2020
@adbridge adbridge merged commit 34a291b into ARMmbed:master Jan 23, 2020
@adbridge adbridge added release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0 and removed ready for merge labels Jan 23, 2020
@mergify
Copy link

mergify bot commented Jan 23, 2020

This PR does not contain release version label after merging.

@jeromecoutant jeromecoutant deleted the PR_REGIONSIZE branch January 23, 2020 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants