-
Notifications
You must be signed in to change notification settings - Fork 3k
Need RAM and ROM size for compilation #12228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@jeromecoutant, thank you for your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
100755 → 100644
Please revert file attributes change
This reverts commit d7e0012
a098355
to
5a69764
Compare
done |
@jeromecoutant Trying to understand for this revert. Can you add a reason to the commit msg (what is actual behavior, that is causing a problem) and how it fixes it ? |
Is this true? If bootloader is not supported, does a target have defined rom/ram sizes ? This could be one of the things I am not completely certain how this information is connected to bootloader (if it actually is). |
As indicated in the description: |
Region sizes doesn't come from bootloader info, they comes from pack manager tool. |
Yes from the manager but they are used/defined only if bootloder is there? My assumption might be wrong, thus asking . |
@ARMmbed/mbed-os-tools Please review I'll run CI meanwhile |
Test run: FAILEDSummary: 1 of 11 test jobs failed Failed test jobs:
|
I would like to have some "generic" linker scripts. So having these region values helps. |
NOTE the ci last ran several days ago and thus this will need to be run again before it can be merged, to ensure no conflicts etc due to other merges in the interim! |
CI restarted |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
This PR does not contain release version label after merging. |
Summary of changes
Previously ROM and RAM sizes comes as linker predefine during mbed build.
Confirmed by:
Looking at https://os.mbed.com/docs/mbed-os/v5.14/porting/porting-bootstrap.html
/* Tools provide -DMBED_ROM_START=xxx -DMBED_ROM_SIZE=xxx -DMBED_RAM_START=xxx -DMBED_RAM_SIZE=xxx */
1 commit is reverted in order to get the expected behavior.
Thx
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Reviewers