Skip to content

TEST: use K64F replace DISCO_L475VG_IOT01A to run some example test #12230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 16, 2020

Conversation

jamesbeyond
Copy link
Contributor

@jamesbeyond jamesbeyond commented Jan 9, 2020

Summary of changes

DISCO_L475VG_IOT01A being slightly overloaded on building/running examples. because it been used heavily on BLE tests.
Also due to DISCO_L475VG_IOT01A not having default connectivity devices.
and NUCLEO_F429ZI not having default storage devices, some CI tests are failing, so
in someplace try to replace those 2 targets with K64F for building and running the examples

Impact of changes

Migration actions required

Documentation

No documents changes required


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@ciarmcom ciarmcom requested review from a team January 9, 2020 18:00
@ciarmcom
Copy link
Member

ciarmcom commented Jan 9, 2020

@jamesbeyond, thank you for your changes.
@ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 13, 2020

DISCO_L475VG_IOT01A being slightly overloaded on building/running examples.

This just fixing the load of CI - not actual failures?

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 13, 2020

Making sure this should be in 6.0.0 alpha1 or not.

@jamesbeyond
Copy link
Contributor Author

jamesbeyond commented Jan 13, 2020

Making sure this should be in 6.0.0 alpha1 or not.

Please mark it as 6.0.0 alpha1 , thanks

@jamesbeyond jamesbeyond requested a review from 0xc0170 January 14, 2020 10:29
@adbridge
Copy link
Contributor

Making sure this should be in 6.0.0 alpha1 or not.

Please mark it as 6.0.0 alpha1 , thanks

Talking to @jamesbeyond this is a CI only fix so marking for alpha 2

@adbridge adbridge added the release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0 label Jan 14, 2020
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add to the commit msg why are we changing these targets, the intention is missing.

As I understood from the answers here, the load on some targets its high and this should balance it better?

- some examples not able run on L475 or F249 target due to missing storage/connectivity capability
- use K64F to run those example test
@jamesbeyond
Copy link
Contributor Author

comment messages have been updated. @0xc0170

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 16, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 16, 2020

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 removed the needs: CI label Jan 16, 2020
@0xc0170 0xc0170 merged commit 4cdd803 into ARMmbed:master Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants