Skip to content

Fix DNS multiple query hints to perform both IP4 and IP6 tests #12239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 15, 2020

Conversation

tymoteuszblochmobica
Copy link
Contributor

Multiple DNS Greentea tests fixed

Summary of changes

Getaddrinfo fails with IP6 interface due to hardcoded IP4 hints.
Replaced query hints with NSAPI_UNSPEC to perform both IP4 and IP6 .

Impact of changes

No impact

Migration actions required

Not needed

Documentation

Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@AnttiKauppila
@SeppoTakalo
@michalpasztamobica

@ciarmcom
Copy link
Member

@tymoteuszblochmobica, thank you for your changes.
@AnttiKauppila @SeppoTakalo @michalpasztamobica @ARMmbed/mbed-os-test @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

Copy link
Contributor

@michalpasztamobica michalpasztamobica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice finding. This looks like a good explanation of why ip6 was failing and a well-targeted fix.

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 13, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 13, 2020

Test run: SUCCESS

Summary: 5 of 5 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added ready for merge release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0 and removed needs: CI labels Jan 13, 2020
@0xc0170 0xc0170 merged commit 40b6f12 into ARMmbed:master Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants