mergify: add fixes to the conditions #12269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As pr-head is neutral, means there was a push, we should test PR again and if all passed, should be marked as ready for merge.
There are two cases here: either PR was in review or needs work. in any case, new CI should be started as pr-head is yellow. Once it completes, based on reviews, we can move to ready for merge or back to needs work if fails.
from review or work - approval and update (pr head yellow) should result in CI run. These 2 preconditions should be sufficient to move to CI stage.
jenkins hooks are not always present, therefore we can't rely on them. Lets rely on not failing for jenkins-ci hooks. This should cover when they are not there due to smart tester, or executed and green. If failed, the condition would be false.
|
@0xc0170, thank you for your changes. |
|
CI started This config needs to be on master to test the feature branch (not valid for any other branches), therefore if it passes, I would like to merge this fixes in. |
Test run: SUCCESSSummary: 12 of 12 test jobs passed |
|
Merging the bot config to continue testing on the feature branch. |
adbridge
added
release-version: 6.0.0-alpha-2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Mergify fixes based on the testing PR. So far working fine, just some conditions were not executed due to errors in the config. This PR is addressing them.
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Reviewers