Fix call to sorted by providing key to sort on. #12275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This call to sorted does nothing in Python 2, as there is no way to sort a list of Exceptions without providing a key. In Python 3 this call fails with an error as there is no comparison implemented for the jsonschema.exceptions.ValidationError Exception. This is fixed by providing the key str, which sorts by the str representation of the Exception.
|
@micque01, thank you for your changes. |
0xc0170
approved these changes
Jan 20, 2020
mark-edgeworth
approved these changes
Jan 20, 2020
|
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
adbridge
added
release-version: 6.0.0-alpha-2
|
This PR does not contain release version label after merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
This is a fix to the tools for running under Python 3.
This call to
sorteddoes nothing in Python 2, as there is no way to sort a list of Exceptions without providing a key. It will simply return the evaluated generator as a list.In Python 3 this call fails with
TypeError : '<' not supported between instances of 'ValidationError' and 'ValidationError', as there is no comparison implemented for thejsonschema.exceptions.ValidationError Exception.This is fixed by providing the key
str, which sorts by the string representation ofthe Exception.
Documentation
None
Pull request type
Test results
Reviewers
@madchutney @mark-edgeworth