Skip to content

Fix for issue #12268 (SerialBase.cpp: fix initialization list) #12282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 23, 2020

Conversation

mprse
Copy link
Contributor

@mprse mprse commented Jan 20, 2020

Summary of changes

This PR fixes issue #12268.
This PR changes the order of the initialization list in SerialBase.cpp. This should fix the compilation warnings.

Snippet from the build which proves that there are no warnings while compiling SerialBase.cpp with this patch:

Compile [  7.4%]: Ticker.cpp
Compile [  7.5%]: SerialBase.cpp
Compile [  7.6%]: Timer.cpp
Compile [  7.8%]: TimerEvent.cpp

Impact of changes

Migration actions required

Documentation


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[X] Tests / results supplied as part of this PR

Reviewers

@JanneKiiskila


@ciarmcom
Copy link
Member

@mprse, thank you for your changes.
@JanneKiiskila @ARMmbed/mbed-os-core @ARMmbed/mbed-os-maintainers please review.

Copy link
Contributor

@JanneKiiskila JanneKiiskila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@adbridge
Copy link
Contributor

@mprse what is the PR type? Please fill this in

@adbridge
Copy link
Contributor

Also when fixing issues, please provide a brief summary of what the issue is and how it has been fixed in the header (rather than just referencing the Issue number).

@mergify mergify bot added needs: CI and removed needs: review labels Jan 20, 2020
@adbridge
Copy link
Contributor

CI started

@adbridge adbridge added the release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0 label Jan 21, 2020
@mbed-ci
Copy link

mbed-ci commented Jan 21, 2020

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@adbridge adbridge merged commit cb53825 into ARMmbed:master Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants