Skip to content

Fix ARM compiler warning for microlib #12303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 24, 2020

Conversation

rajkan01
Copy link
Contributor

@rajkan01 rajkan01 commented Jan 22, 2020

Summary of changes

  • if the "target.c_lib": "small" is configured in the build tool, then ARM compiler issues a warning as [DEBUG] Output: armclang: warning: -Wl,--library_type=microlib: 'linker' input unused [-Wunused-command-line-argument] .
  • The reported issue is solved by adding that flag only in the linker configuration as per docs.

Impact of changes

With these changes, compiler warning about unused command-line argument should go away.

Migration actions required

None.

Documentation

None.


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@evedon


- Remove the --library_type=micorlib from c/cxx configuration.
@ciarmcom ciarmcom requested review from evedon and a team January 22, 2020 16:00
@ciarmcom
Copy link
Member

@rajkan01, thank you for your changes.
@evedon @ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

@mergify mergify bot added needs: CI and removed needs: work labels Jan 23, 2020
@adbridge
Copy link
Contributor

The reported issue is solved by adding that flag only in the linker configuration as per docs.

And is this flag in the linker configuration ?

@adbridge
Copy link
Contributor

CI started

@adbridge
Copy link
Contributor

@rajkan01 looks like you have some genuine errors. For ARCHPRO for example:
[2020-01-24T11:09:04.227Z] Compile [ 6.6%]: USBCDC_ECM.cpp
[2020-01-24T11:09:04.227Z] [ERROR] ./drivers/source/usb/USBCDC_ECM.cpp:558:1: internal compiler error: in output_die, at dwarf2out.c:10807
[2020-01-24T11:09:04.227Z] 558 | }
[2020-01-24T11:09:04.227Z] | ^

@rajkan01
Copy link
Contributor Author

@rajkan01 looks like you have some genuine errors. For ARCHPRO for example:
[2020-01-24T11:09:04.227Z] Compile [ 6.6%]: USBCDC_ECM.cpp
[2020-01-24T11:09:04.227Z] [ERROR] ./drivers/source/usb/USBCDC_ECM.cpp:558:1: internal compiler error: in output_die, at dwarf2out.c:10807
[2020-01-24T11:09:04.227Z] 558 | }
[2020-01-24T11:09:04.227Z] | ^

This PR changes related to ARM toolchain with microlib library but failure in GCC_ARM. Please restart the CI.

@mbed-ci
Copy link

mbed-ci commented Jan 24, 2020

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_build-ARM

@adbridge
Copy link
Contributor

CI restarted

@mbed-ci
Copy link

mbed-ci commented Jan 24, 2020

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

@adbridge adbridge merged commit 7101e92 into ARMmbed:master Jan 24, 2020
@adbridge adbridge added release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0 and removed ready for merge labels Jan 24, 2020
@mergify
Copy link

mergify bot commented Jan 24, 2020

This PR does not contain release version label after merging.

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 3, 2020

This PR does not contain release version label after merging.

I'll look at this shortly. It should be fine as it has release version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants