Cellular: Remove support for multiple ATHandlers #12305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Major changes: - Dependency to FileHandle removed from base classes - AT_CellularDevice owns the default FileHandle and shares it with AT -classes - Hang-up -detection moved as CellularContext::configure_hup(). Cannot be configured via CellularDevice any more. Result on NRF52840_DK + BG96: GCC: Total Static RAM memory (data + bss): 29360(+296) bytes Total Flash memory (text + data): 130660(-832) bytes ARM: Total Static RAM memory (data + bss): 261554(+8) bytes Total Flash memory (text + data): 127573(-1193) bytes IAR: Total Static RAM memory (data + bss): 25479(+296) bytes Total Flash memory (text + data): 102418(-527) bytes RAM increase is because now ATHandler is no longer created with new -operator but is now member of AT_CellularDevice, so image tool is able to count it. Actually total RAM consumption has decreased due to removed variables.
AriParkkila
approved these changes
Jan 23, 2020
|
@kivaisan, thank you for your changes. |
|
@kivaisan thank you for a well documented PR template :) |
|
@kjbracey-arm could you please review ? |
|
Let's resume the reviews! |
AnttiKauppila
approved these changes
Feb 6, 2020
|
CI started |
0xc0170
approved these changes
Feb 6, 2020
bulislaw
approved these changes
Feb 6, 2020
0xc0170
added
the
release-version: 6.0.0-alpha-2
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
This commit removes multi
ATHandlersupport from cellular. This has not been used and causes unnecessary complexity and memory consumption.Memory statistics of mbed-os-example-cellular with NRF52840_DK + BG96:
GCC:
Total Static RAM memory (data + bss): 29360(+296) bytes
Total Flash memory (text + data): 130660(-832) bytes
ARM:
Total Static RAM memory (data + bss): 261554(+8) bytes
Total Flash memory (text + data): 127573(-1193) bytes
IAR:
Total Static RAM memory (data + bss): 25479(+296) bytes
Total Flash memory (text + data): 102418(-527) bytes
RAM increase is because now
ATHandleris no longer created with new -operator but is now member ofAT_CellularDevice, so image tool is able to count it. Actual total RAM consumption has decreased due to removed variables.Impact of changes
Major changes:
AT_CellularDeviceowns the defaultFileHandleand shares it with AT -classesCellularContext::configure_hup(). Cannot be configured viaCellularDeviceany more.Migration actions required
CellularContext::configure_hup(). CellularDevice::enable_hup() and context creation with BufferedSerial handle removed. Cellular will now automatically enable and disable HUP when switching between AT and PPP mode.CellularDevice::create_context()no longer takesFileHandleas parameterCellularDevice::get_file_handle()removed.ATHandler::get_file_handle() can be used instead.Documentation
Pull request type
Test results
Reviewers
@ARMmbed/mbed-os-wan @kjbracey-arm