Skip to content

Fix the missing retrieve error context function call. #12307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 25, 2020
Merged

Fix the missing retrieve error context function call. #12307

merged 1 commit into from
Jan 25, 2020

Conversation

rajkan01
Copy link
Contributor

@rajkan01 rajkan01 commented Jan 23, 2020 •
edited
Loading

Summary of changes

  • Add the missing function call to retrieve error context after a fatal error at the system initialisation for the bare metal profile.

Impact of changes

With these changes, Crash reporting bare metal green tea test can retrieve the injected fatal error report.

Migration actions required

None.

Documentation

None.

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@evedon

@rajkan01
Fix for the missing retrieve error context function call.
f1e1375 
 - Add the function to retrieve error context after a fatal error is called at
   system initialisation for the bare metal profile.
@rajkan01 rajkan01 changed the title Fix for the missing retrieve error context function call. Fix the missing retrieve error context function call. Jan 23, 2020
@ciarmcom ciarmcom requested review from evedon and a team January 23, 2020 16:00
@ciarmcom
Copy link
Member

@rajkan01, thank you for your changes.
@evedon @ARMmbed/mbed-os-core @ARMmbed/mbed-os-maintainers please review.

evedon
evedon approved these changes Jan 23, 2020
View reviewed changes
Copy link
Contributor

@evedon evedon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@mergify mergify bot added needs: CI and removed needs: review labels Jan 23, 2020
@adbridge
Copy link
Contributor

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 24, 2020

Test run: FAILED

Summary: 2 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-ARM

@adbridge
Copy link
Contributor

Looks like some ci issues, restarted

@mbed-ci
Copy link

mbed-ci commented Jan 24, 2020

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

@adbridge adbridge merged commit f469f71 into ARMmbed:master Jan 25, 2020
@mergify mergify bot removed the ready for merge label Jan 25, 2020
@mergify
Copy link

mergify bot commented Jan 25, 2020

This PR does not contain release version label after merging.

@adbridge adbridge added release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0 and removed Release review required labels Jan 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adbridge adbridge adbridge approved these changes

@evedon evedon evedon approved these changes

Assignees
No one assigned
Labels
release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rajkan01 @ciarmcom @adbridge @mbed-ci @evedon