Skip to content

FIX: Disable Analogin D13(PA_5) on some NUCLEO targets #12332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 3, 2020
Merged

FIX: Disable Analogin D13(PA_5) on some NUCLEO targets #12332

merged 1 commit into from
Feb 3, 2020

Conversation

jamesbeyond
Copy link
Contributor

Summary of changes

On NUCLEO_F411RE , NUCLEO_F303RE and NUCLEO_L073RZ those PA_5 pins can not be used as analogin. This failed the FPGA analogIn tests.
The original changes were introduced in #11682 , but it seems it somehow got reverted by accident.
So introduced the fix again

Impact of changes

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@mprse

@ciarmcom ciarmcom requested review from mprse and a team January 29, 2020 18:00
@ciarmcom
Copy link
Member

@jamesbeyond, thank you for your changes.
@mprse @ARMmbed/mbed-os-maintainers please review.

jeromecoutant
jeromecoutant approved these changes Jan 30, 2020
View reviewed changes
Copy link
Collaborator

@jeromecoutant jeromecoutant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, as pins are connected to the LED, it can't be used as analogin

@jamesbeyond jamesbeyond requested review from 0xc0170 and removed request for a team February 3, 2020 11:01
@0xc0170
Copy link
Contributor

0xc0170 commented Feb 3, 2020

Yes, as pins are connected to the LED, it can't be used as analogin

@jamesbeyond Can you add this to the commit msg?

0xc0170
0xc0170 previously requested changes Feb 3, 2020
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add disabling reason to the commit msg (LED connected)

Disable Analogin D13(PA_5) on some NUCLEO targets
f7d9850 
- pins are connected to the LED, can't be used as analogin
@mergify mergify bot dismissed 0xc0170’s stale review February 3, 2020 11:43

Pull request has been modified.

@jamesbeyond
Copy link
Contributor Author

comment message has been added. @0xc0170

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 3, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Feb 3, 2020

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added the release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0 label Feb 3, 2020
@0xc0170 0xc0170 merged commit 0f4a986 into ARMmbed:master Feb 3, 2020
@mergify mergify bot removed the ready for merge label Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@jeromecoutant jeromecoutant jeromecoutant approved these changes

@mprse mprse mprse approved these changes

Assignees
No one assigned
Labels
release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jamesbeyond @ciarmcom @0xc0170 @mbed-ci @jeromecoutant @mprse