Skip to content

Update cellular drivers/tests for UBLOX_C030_R412M #12334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 5, 2020

Conversation

AriParkkila
Copy link

Summary of changes

Update cellular drivers/tests for UBLOX_C030_R412M:

  • Enable IP over PPP on UBLOX_C030_R41XM
  • Fix UBLOX_AT UDP/IP driver
  • Fix UDPSOCKET_ECHOTEST to handle oversized packets
  • Enable SYNCHRONOUS_DNS_CACHE just for NSAPI_PPP_AVAILABLE
  • Add UBLOX_C030_R412M target in CellularInterface.json

Impact of changes

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Mbed OS greentea tests PASS with mbed test -m UBLOX_C030_R412M --app-config tools/test_configs/CellularInterface.json:

  • Test suites -n network-interface / tests-netsocket-*
  • On both LWIP and modem IP stack: lwip.ppp-enabled: true/false

Reviewers

@ARMmbed/team-ublox


@ciarmcom ciarmcom requested review from a team January 30, 2020 10:00
@ciarmcom
Copy link
Member

@AriParkkila, thank you for your changes.
@ARMmbed/mbed-os-wan @ARMmbed/mbed-os-tools @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-test @ARMmbed/mbed-os-maintainers please review.

AnttiKauppila
AnttiKauppila previously approved these changes Jan 30, 2020
@mergify mergify bot added needs: CI and removed needs: review labels Jan 30, 2020
@mergify mergify bot dismissed AnttiKauppila’s stale review January 30, 2020 12:32

Pull request has been modified.

@AriParkkila AriParkkila requested a review from kivaisan January 30, 2020 12:33
@0xc0170
Copy link
Contributor

0xc0170 commented Feb 3, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Feb 3, 2020

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added the release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0 label Feb 3, 2020
@0xc0170 0xc0170 requested a review from a team February 3, 2020 17:02
@0xc0170
Copy link
Contributor

0xc0170 commented Feb 3, 2020

This PR shall be ready, but @ARMmbed/team-ublox was requested for review.

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 5, 2020

@ARMmbed/team-ublox We will move forward. If something found, will be treated separately.

@0xc0170 0xc0170 merged commit e3ad1ca into ARMmbed:master Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants