Skip to content

Unittests for DNS improvements #12344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 31, 2020
Merged

Unittests for DNS improvements #12344

merged 2 commits into from
Jan 31, 2020

Conversation

michalpasztamobica
Copy link
Contributor

Summary of changes

  1. The path was changed from MODULETESTS to moduletests, which avoids directory duplication in Unix systems.
  2. The test file was renamed to moduletest.cpp to allow filtering "moduletest" (see unittest: fix coverage filtering #12263 (comment))
  3. I removed the hand-crafted getaddrinfo and replaced it with the proper one from NetworkInterface. Testing getaddrinfo_async is more tricky and in fact would not increase the coverage too much, so I'll leave it as is.

Impact of changes

The UNITTESTS/MODULETESTS directory will seize to exist. Only UNITTESTS/moduletests will be there.

Migration actions required

None

Documentation

None

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[x] Tests / results supplied as part of this PR

Reviewers

@AnttiKauppila
@SeppoTakalo

@michalpasztamobica
Unittests: DNS - fix path and filename
6d71add
@michalpasztamobica
Unittests: DNS - use the real getaddrinfo function
03fcc3a 
This was recently added to NetworkInterface. Earlier a temporary function was put into the test to mimic that behavior.
@ciarmcom
Copy link
Member

@michalpasztamobica, thank you for your changes.
@AnttiKauppila @SeppoTakalo @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested review from SeppoTakalo and a team January 31, 2020 08:00
@mergify mergify bot added needs: CI and removed needs: review labels Jan 31, 2020
@jamesbeyond
Copy link
Contributor

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 31, 2020

Test run: SUCCESS

Summary: 1 of 1 test jobs passed
Build number : 1
Build artifacts

@kjbracey kjbracey merged commit 1aa3b8f into ARMmbed:master Jan 31, 2020
@mergify mergify bot removed the ready for merge label Jan 31, 2020
@mergify
Copy link

mergify bot commented Jan 31, 2020

This PR does not contain release version label after merging.

@0xc0170 0xc0170 added release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0 and removed Release review required labels Feb 4, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Feb 4, 2020

I've fixed the version: Set to 6.0.0-alpha-2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeppoTakalo SeppoTakalo SeppoTakalo approved these changes

@kjbracey kjbracey kjbracey approved these changes

@AnttiKauppila AnttiKauppila Awaiting requested review from AnttiKauppila

Assignees
No one assigned
Labels
release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@michalpasztamobica @ciarmcom @jamesbeyond @mbed-ci @0xc0170 @SeppoTakalo @kjbracey