Skip to content

implements i2c_free for STM #12350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 3, 2020
Merged

implements i2c_free for STM #12350

merged 2 commits into from
Feb 3, 2020

Conversation

maciejbocianski
Copy link
Contributor

@maciejbocianski maciejbocianski commented Jan 31, 2020 •
edited
Loading

Summary of changes

To fix i2c fpga test on F411RE :

  • implement i2c_free function for STM
  • remove PA_8 pin from F411RE I2C pinmap

below results for F411RE (without and with fix)

| target                | platform_name | test suite                             | test case                              | passed | failed | result  | elapsed_time (sec) |
|-----------------------|---------------|----------------------------------------|----------------------------------------|--------|--------|---------|--------------------|
| NUCLEO_F411RE-GCC_ARM | NUCLEO_F411RE | tests-mbed_hal_fpga_ci_test_shield-i2c | i2c (direct init) - test read i2c API  | 0      | 0      | SKIPPED | 0.0                |
| NUCLEO_F411RE-GCC_ARM | NUCLEO_F411RE | tests-mbed_hal_fpga_ci_test_shield-i2c | i2c (direct init) - test write i2c API | 0      | 0      | SKIPPED | 0.0                |
| NUCLEO_F411RE-GCC_ARM | NUCLEO_F411RE | tests-mbed_hal_fpga_ci_test_shield-i2c | i2c - init/free test all pins          | 1      | 0      | OK      | 0.74               |
| NUCLEO_F411RE-GCC_ARM | NUCLEO_F411RE | tests-mbed_hal_fpga_ci_test_shield-i2c | i2c - test read i2c API                | 0      | 0      | SKIPPED | 0.0                |
| NUCLEO_F411RE-GCC_ARM | NUCLEO_F411RE | tests-mbed_hal_fpga_ci_test_shield-i2c | i2c - test single byte read i2c API    | 0      | 0      | SKIPPED | 0.0                |
| NUCLEO_F411RE-GCC_ARM | NUCLEO_F411RE | tests-mbed_hal_fpga_ci_test_shield-i2c | i2c - test single byte write i2c API   | 0      | 0      | SKIPPED | 0.0                |
| NUCLEO_F411RE-GCC_ARM | NUCLEO_F411RE | tests-mbed_hal_fpga_ci_test_shield-i2c | i2c - test write i2c API               | 0      | 1      | FAIL    | 0.26               |

| target                | platform_name | test suite                             | test case                              | passed | failed | result | elapsed_time (sec) |
|-----------------------|---------------|----------------------------------------|----------------------------------------|--------|--------|--------|--------------------|
| NUCLEO_F411RE-GCC_ARM | NUCLEO_F411RE | tests-mbed_hal_fpga_ci_test_shield-i2c | i2c (direct init) - test read i2c API  | 1      | 0      | OK     | 0.52               |
| NUCLEO_F411RE-GCC_ARM | NUCLEO_F411RE | tests-mbed_hal_fpga_ci_test_shield-i2c | i2c (direct init) - test write i2c API | 1      | 0      | OK     | 0.53               |
| NUCLEO_F411RE-GCC_ARM | NUCLEO_F411RE | tests-mbed_hal_fpga_ci_test_shield-i2c | i2c - init/free test all pins          | 1      | 0      | OK     | 0.6                |
| NUCLEO_F411RE-GCC_ARM | NUCLEO_F411RE | tests-mbed_hal_fpga_ci_test_shield-i2c | i2c - test read i2c API                | 1      | 0      | OK     | 0.5                |
| NUCLEO_F411RE-GCC_ARM | NUCLEO_F411RE | tests-mbed_hal_fpga_ci_test_shield-i2c | i2c - test single byte read i2c API    | 1      | 0      | OK     | 0.5                |
| NUCLEO_F411RE-GCC_ARM | NUCLEO_F411RE | tests-mbed_hal_fpga_ci_test_shield-i2c | i2c - test single byte write i2c API   | 1      | 0      | OK     | 0.52               |
| NUCLEO_F411RE-GCC_ARM | NUCLEO_F411RE | tests-mbed_hal_fpga_ci_test_shield-i2c | i2c - test write i2c API               | 1      | 0      | OK     | 0.5                |

Impact of changes

Migration actions required

Documentation

Pull request type 

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[X] Tests / results supplied as part of this PR

Reviewers

@jamesbeyond

@jeromecoutant
Copy link
Collaborator

@ARMmbed/team-st-mcd

jamesbeyond
jamesbeyond approved these changes Jan 31, 2020
View reviewed changes
Copy link
Contributor

@jamesbeyond jamesbeyond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot added the needs: CI label Jan 31, 2020
@jamesbeyond
Copy link
Contributor

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 31, 2020

Test run: FAILED

Summary: 1 of 12 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_exporter

@jamesbeyond
Copy link
Contributor

The failed Exporter tests are not relevant.
CI restarted

@mbed-ci
Copy link

mbed-ci commented Feb 1, 2020

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 2
Build artifacts

@0xc0170 0xc0170 merged commit 02c5e08 into ARMmbed:master Feb 3, 2020
@0xc0170 0xc0170 added the release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0 label Feb 3, 2020
@mergify mergify bot removed the ready for merge label Feb 3, 2020
@mergify
Copy link

mergify bot commented Feb 3, 2020

This PR does not contain release version label after merging.

@0xc0170 0xc0170 removed the release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0 label Feb 3, 2020
@mergify
Copy link

mergify bot commented Feb 3, 2020

This PR does not contain release version label after merging.

@0xc0170 0xc0170 added release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0 and removed Release review required labels Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@LMESTM LMESTM LMESTM approved these changes

@jamesbeyond jamesbeyond jamesbeyond approved these changes

Assignees
No one assigned
Labels
release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@maciejbocianski @jeromecoutant @jamesbeyond @mbed-ci @0xc0170 @LMESTM