Fix NRF51, NRF52 gpio_irq_init() function #12356
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
According to the description in
gpio_irq_hal_api.h
filegpio_irq_init()
should return 0 on success:mbed-os/hal/gpio_irq_api.h
Line 79 in 0f4a986
Currently, it returns 1 causing the FPGA test to fail.
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Reviewers
@jamesbeyond @maciejbocianski @fkjagodzinski @0xc0170