Skip to content

TARGET_STM32F1: don't set ADC common register when ADC doesn't support it #12357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 4, 2020
Merged

TARGET_STM32F1: don't set ADC common register when ADC doesn't support it #12357

merged 1 commit into from
Feb 4, 2020

Conversation

ABOSTM
Copy link
Contributor

@ABOSTM ABOSTM commented Feb 3, 2020

Summary of changes

TARGET_STM32F1: don't set ADC common register when ADC doesn't support it

STM32F103ZE: ADC3 doesn't support common settings.
__LL_ADC_COMMON_INSTANCE(ADC3) returns 0

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

@ABOSTM
TARGET_STM32F1: don't set ADC common register when ADC doesn't suppor…
03b03fe 
…t it

STM32F103ZE: ADC3 doesn't support common settings.
__LL_ADC_COMMON_INSTANCE(ADC3) returns 0
@ciarmcom
Copy link
Member

ciarmcom commented Feb 3, 2020

@ABOSTM, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from a team February 3, 2020 16:00
@mergify mergify bot added needs: CI and removed needs: review labels Feb 4, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Feb 4, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Feb 4, 2020

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added the release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0 label Feb 4, 2020
@0xc0170 0xc0170 merged commit cee2a35 into ARMmbed:master Feb 4, 2020
@mergify mergify bot removed the ready for merge label Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bulislaw bulislaw bulislaw approved these changes

@jeromecoutant jeromecoutant jeromecoutant approved these changes

Assignees
No one assigned
Labels
release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ABOSTM @ciarmcom @0xc0170 @mbed-ci @bulislaw @jeromecoutant