Skip to content

Mergify: fix release version label #12363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 4, 2020

Conversation

0xc0170
Copy link
Contributor

@0xc0170 0xc0170 commented Feb 4, 2020

Check if release review is not applied for merged PR. If not, we use "release version missing" label.

Summary of changes

Adding new label to cover when PR is not versioned. Fixing the current behavior.
Note @ARMmbed/mbed-os-maintainers Before merging, please make sure PR is either "Release review required" or "release-version" to mark versions correctly.

Impact of changes

Migration actions required

Documentation


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[X] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


Check if release review is not applied for merged PR. If not, we use "release version missing" label.
@0xc0170 0xc0170 requested a review from adbridge February 4, 2020 13:40
@0xc0170
Copy link
Contributor Author

0xc0170 commented Feb 4, 2020

Tested with mergify simulator on PR #12321 (has review release label):

#### Rule: release version is a must for merged PRs (label, comment)
- [X] `merged`
- [X] `-label~=^(release-version)`
- [ ] `-label~=^(Release review required)`

and Pr without any label for release (review or version):

#### Rule: release version is a must for merged PRs (label, comment)
- [X] `merged`
- [X] `-label~=^(release-version)`
- [X] `-label~=^(Release review required)`

@ciarmcom ciarmcom requested a review from a team February 4, 2020 14:00
@ciarmcom
Copy link
Member

ciarmcom commented Feb 4, 2020

@0xc0170, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@adbridge
Copy link
Contributor

adbridge commented Feb 4, 2020

LGTM

@0xc0170
Copy link
Contributor Author

0xc0170 commented Feb 4, 2020

CI started

@0xc0170 0xc0170 added release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0 and removed needs: CI labels Feb 4, 2020
@0xc0170 0xc0170 merged commit 0b7c78b into ARMmbed:master Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants