Skip to content

OKDO_ODIN_W2: Reenable lp-ticker and BLE #12365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

OKDO_ODIN_W2: Reenable lp-ticker and BLE #12365

wants to merge 1 commit into from

Conversation

MarceloSalazar
Copy link

Summary of changes

This reenables LPTICKER and BLE to fix the link problem reported in #12361

[DEBUG] Errors: Error: L6218E: Undefined symbol hciCmdAlloc (referred from ./mbed-os/targets/TARGET_STM/TARGET_STM32F4/TARGET_STM32F439xI/TARGET_MODULE_UBLOX_ODIN_W2/sdk/TOOLCHAIN_ARM/libublox-odin-w2-driver.ar(hci_vendor_cmd.o)).
[DEBUG] Errors: Error: L6218E: Undefined symbol hciCmdSend (referred from ./mbed-os/targets/TARGET_STM/TARGET_STM32F4/TARGET_STM32F439xI/TARGET_MODULE_UBLOX_ODIN_W2/sdk/TOOLCHAIN_ARM/libublox-odin-w2-driver.ar(hci_vendor_cmd.o)).

Impact of changes

Fixes link problem when compiling mbed-os-example-blinky.
Code runs ok on OKDO_ODIN_W2 platform and timer/ticker tests pass.
OKDO_timer-ticker-tests.txt

Migration actions required

NA

Documentation

NA


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[x] Tests / results supplied as part of this PR

Reviewers

@0xc0170 @ARMmbed/team-ublox


@MarceloSalazar
Copy link
Author

Please review asap as need to get merged for 5.15.1

@ciarmcom ciarmcom requested review from 0xc0170 and a team February 4, 2020 22:00
@ciarmcom
Copy link
Member

ciarmcom commented Feb 4, 2020

@MarceloSalazar, thank you for your changes.
@0xc0170 @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 5, 2020

Besides for 5.15.1, also fixing nightly error.

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 5, 2020

I don't see this one in Travis. I'll close and reopen after jenkins completes the job.

@mbed-ci
Copy link

mbed-ci commented Feb 5, 2020

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 5, 2020

Closing to reopen for Travis to pick it up

@0xc0170 0xc0170 closed this Feb 5, 2020
@0xc0170 0xc0170 reopened this Feb 5, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Feb 5, 2020

I found this PR in the history, it is "abuse detected" , see https://travis-ci.community/t/some-pr-are-not-analyzed-with-message-abuse-detected/1191/8

@MarceloSalazar If you can log in to travis to make sure you are know for Travis. If that does not help, lets try to reach their suppor to fix this.

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 5, 2020

To quickly progress here, if this does not help, I can recreate PR and put it in CI asap. I'll prepare it in the meantime

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 5, 2020

Still abuse detected. @MarceloSalazar Can you contact travis as instructed in the community (link I shared above) ? I'll close this and recreate this via my fork now

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 5, 2020

The PR was merged via 12370

@0xc0170 0xc0170 closed this Feb 5, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Feb 5, 2020

The PR was merged via 12370

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants