Fix psa_key_management_operations #12392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At these locations, psa_key_attribute variables are used without initialisation. The function getting it (psa_get_key_attributes), is freeing attributes->domain_parameters, which can contain random address from the stack. Signed-off-by: Gabor Abonyi <[email protected]>
|
@GaborAbonyi, thank you for your changes. |
bulislaw
approved these changes
Feb 10, 2020
0xc0170
added
the
release-version: 6.0.0-alpha-2
|
CI started |
0xc0170
approved these changes
Feb 10, 2020
Patater
approved these changes
Feb 10, 2020
Test run: FAILEDSummary: 1 of 11 test jobs failed Failed test jobs:
|
|
I restarted tests to confirm the failures. @GaborAbonyi please review artifacts above (Build artifacts url reference) to find test failures. |
|
Thanks @0xc0170 . I checked the artifacts but not sure what causes the issue, as it is only present for one target, with one specific compiler. It is possible that there is another uninitialized variable case that is now surfaced. |
|
Second run all good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Fix psa_key_management_operations for PSA_GET_KEY_ATTRIBUTES and PSA_IMPORT_KEY.
At these locations, psa_key_attribute variables are used without initialisation.
The function getting it (psa_get_key_attributes), is freeing attributes->domain_parameters, which can contain random address from the stack.
Impact of changes
Fix of intermittent errors.
Migration actions required
Documentation
N/A
Pull request type
Test results
Reviewers