Cellular: Delete created context if activation fails #12399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If new context is created but the activation fails to any error, it will be automatically deleted. Fixes issue #12381
AnttiKauppila
approved these changes
Feb 10, 2020
|
|
||
| err = (_at.get_last_error() == NSAPI_ERROR_OK) ? NSAPI_ERROR_OK : NSAPI_ERROR_NO_CONNECTION; | ||
| err = (_at.get_last_error() == NSAPI_ERROR_OK) ? NSAPI_ERROR_OK : NSAPI_ERROR_NO_CONNECTION; | ||
| } | ||
|
|
||
| // If new PDP context was created and failed to activate, delete it | ||
| if (err != NSAPI_ERROR_OK && _new_context_set) { |
There was a problem hiding this comment.
Should we keep this _new_context_set condition ?
Ex: A wrong context configuration was already present in modem,
Maybe we should delete all context when connection has failed?
There was a problem hiding this comment.
I don't think we should remove contexts not created automatically by cellular. Could it cause problems with devices roaming in different networks? We have "cellular.clear-on-connect" setting which can be (kind of) used to handle this case.
There was a problem hiding this comment.
oh
Let's try in my mbed_app:
"cellular.clear-on-connect": true
Maybe it can also help @soleilplanet ?
0xc0170
approved these changes
Feb 10, 2020
|
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
0xc0170
added
the
release-version: 6.0.0-alpha-2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
If new context is created but the activation fails to any error, it will
be automatically deleted.
Fixes issue #12381
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Reviewers
@ARMmbed/mbed-os-wan @jeromecoutant