-
Notifications
You must be signed in to change notification settings - Fork 3k
Add an exception for ARMC5 toolchain build #12400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@rajkan01, thank you for your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this warning-error all we need do - there is still code related to ARM5 in the tools/targets, we remove it separately but still within 6.0 version?
There are currently 68 references to ARMC5 in mbed-os. What is the plan to remove these? |
Started CI while we complete the review |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Not yet ready for integration, @bulislaw Please approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good first step, but I'd like us to remove all the dead code that's there for ARMC5 support and compatibility.
Summary of changes
The Arm Compiler 5 is no longer supported so removed the deprecate warning and added the exception in the build tool to stop building with ARM compiler 5.
Impact of changes
With these changes, Arm compiler 5 build fails
Migration actions required
Upgrade the enviroment to use Arm Compiler 6 refer
Documentation
Pull request type
Test results
Reviewers
@evedon @madchutney